From: Jason Wang <jasowang@redhat.com>
To: Li Zhijian <lizhijian@cn.fujitsu.com>,
Yang Hongyang <hongyang.yang@easystack.cn>,
Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Cc: Gui jianfeng <guijianfeng@cn.fujitsu.com>,
"eddie.dong" <eddie.dong@intel.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] net/filter: rename qemu_netfilter_pass_to_next() to qemu_netfilter_iterate()
Date: Tue, 15 Mar 2016 11:08:49 +0800 [thread overview]
Message-ID: <56E77CC1.7050307@redhat.com> (raw)
In-Reply-To: <56DFD89E.4040508@cn.fujitsu.com>
On 03/09/2016 04:02 PM, Li Zhijian wrote:
>
>
> On 03/08/2016 04:04 PM, Yang Hongyang wrote:
>> Hi Chen,
>>
>> What's the motivation that you want to change this name? The
>> function actually is not
>> intent to iterate every filter.
>
> Right. but this function isn't always pass packet to *a* next filter.
> Actually, it iterates filters until the packet is stolen(filter
> receiving handler return non-zero).
> In other words, packet could be handled by several filters at this
> function.
>
> BTW, it's difficult to determine what name is better.
>
> Thanks
> Li Zhijian
Right, so I was considering a better function name (though I'm not a
native English speaker).
But I agree qemu_netfilter_iterate() is not perfect too, may need more
thought.
next prev parent reply other threads:[~2016-03-15 3:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 10:03 [Qemu-devel] [PATCH] net/filter: rename qemu_netfilter_pass_to_next() to qemu_netfilter_iterate() Zhang Chen
2016-03-08 8:04 ` Yang Hongyang
2016-03-09 8:02 ` Li Zhijian
2016-03-15 3:08 ` Jason Wang [this message]
2016-03-15 3:33 ` Li Zhijian
2016-03-15 3:42 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E77CC1.7050307@redhat.com \
--to=jasowang@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eddie.dong@intel.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=hongyang.yang@easystack.cn \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).