From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49254)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1affLx-0006zK-Hr
	for qemu-devel@nongnu.org; Mon, 14 Mar 2016 23:09:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1affLt-0000Ms-I5
	for qemu-devel@nongnu.org; Mon, 14 Mar 2016 23:09:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48068)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1affLt-0000Mn-CN
	for qemu-devel@nongnu.org; Mon, 14 Mar 2016 23:08:57 -0400
References: <1457345011-17645-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<CAN+wFu+P3J89SzxV-=nS+hziXqQ4DFi7mWpFkDNR_i47MXNhgQ@mail.gmail.com>
	<56DFD89E.4040508@cn.fujitsu.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56E77CC1.7050307@redhat.com>
Date: Tue, 15 Mar 2016 11:08:49 +0800
MIME-Version: 1.0
In-Reply-To: <56DFD89E.4040508@cn.fujitsu.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] net/filter: rename
 qemu_netfilter_pass_to_next() to qemu_netfilter_iterate()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Li Zhijian <lizhijian@cn.fujitsu.com>, Yang Hongyang <hongyang.yang@easystack.cn>, Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Cc: Gui jianfeng <guijianfeng@cn.fujitsu.com>, "eddie.dong" <eddie.dong@intel.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu devel <qemu-devel@nongnu.org>



On 03/09/2016 04:02 PM, Li Zhijian wrote:
>
>
> On 03/08/2016 04:04 PM, Yang Hongyang wrote:
>> Hi Chen,
>>
>>    What's the motivation that you want to change this name? The
>> function actually is not
>> intent to iterate every filter.
>
> Right. but this function isn't always pass packet to *a* next filter.
> Actually, it iterates filters until the packet is stolen(filter
> receiving handler return non-zero).
> In other words, packet could be handled by several filters at this
> function.
>
> BTW, it's difficult to determine what name is better.
>
> Thanks
> Li Zhijian 

Right, so I was considering a better function name (though I'm not a
native English speaker).

But I agree qemu_netfilter_iterate() is not perfect too, may need more
thought.