From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1affs9-0003Fw-51 for qemu-devel@nongnu.org; Mon, 14 Mar 2016 23:42:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1affs4-0001g4-1U for qemu-devel@nongnu.org; Mon, 14 Mar 2016 23:42:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1affs3-0001g0-Rr for qemu-devel@nongnu.org; Mon, 14 Mar 2016 23:42:11 -0400 References: <1457345011-17645-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> <56DFD89E.4040508@cn.fujitsu.com> <56E77CC1.7050307@redhat.com> <56E78299.9040102@cn.fujitsu.com> From: Jason Wang Message-ID: <56E7848D.5020601@redhat.com> Date: Tue, 15 Mar 2016 11:42:05 +0800 MIME-Version: 1.0 In-Reply-To: <56E78299.9040102@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] net/filter: rename qemu_netfilter_pass_to_next() to qemu_netfilter_iterate() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Li Zhijian , Yang Hongyang , Zhang Chen Cc: qemu devel , Gui jianfeng , "eddie.dong" , zhanghailiang , "Dr. David Alan Gilbert" On 03/15/2016 11:33 AM, Li Zhijian wrote: > > > On 03/15/2016 11:08 AM, Jason Wang wrote: >> >> >> On 03/09/2016 04:02 PM, Li Zhijian wrote: >>> >>> >>> On 03/08/2016 04:04 PM, Yang Hongyang wrote: >>>> Hi Chen, >>>> >>>> What's the motivation that you want to change this name? The >>>> function actually is not >>>> intent to iterate every filter. >>> >>> Right. but this function isn't always pass packet to *a* next filter. >>> Actually, it iterates filters until the packet is stolen(filter >>> receiving handler return non-zero). >>> In other words, packet could be handled by several filters at this >>> function. >>> >>> BTW, it's difficult to determine what name is better. >>> >>> Thanks >>> Li Zhijian >> >> Right, so I was considering a better function name (though I'm not a >> native English speaker). >> >> But I agree qemu_netfilter_iterate() is not perfect too, may need more >> thought. >> >> > let's drop this patch temporarily ? > > Thanks > Li Zhijian > Right, let's change it when we have a better name. Thanks