From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] Our use of #include is undisciplined, and what to do about it
Date: Tue, 15 Mar 2016 10:40:20 +0100 [thread overview]
Message-ID: <56E7D884.902@redhat.com> (raw)
In-Reply-To: <87wpp4m6n1.fsf@blackfin.pond.sub.org>
On 15/03/2016 10:29, Markus Armbruster wrote:
> NEED_CPU_H further adds
>
> include/disas/bfd.h
> include/exec/cpu-all.h
> include/exec/cpu-common.h
> include/exec/cpu-defs.h
> include/exec/exec-all.h
> include/exec/hwaddr.h
> include/exec/memattrs.h
> include/exec/memory.h
> include/hw/hotplug.h
> include/hw/i386/apic.h
> include/hw/irq.h
> include/hw/qdev-core.h
> include/qemu/bitmap.h
> include/qemu/bitops.h
> include/qemu/int128.h
> include/qemu/log.h
> include/qemu/notify.h
> include/qemu/rcu.h
> include/qemu/thread-posix.h
> include/qemu/thread.h
> include/qom/cpu.h
> include/qom/object.h
> include/standard-headers/asm-x86/hyperv.h
> include/standard-headers/linux/types.h
> target-i386/cpu-qom.h
> target-i386/cpu.h
> target-i386/svm.h
> tcg/i386/tcg-target.h
> x86_64-softmmu/config-target.h
FWIW, I'm going to do something about this in 2.7. I have patches to
remove cpu.h inclusion from qemu-common.h.
Generally though qemu-common.h needs to go. :)
Paolo
next prev parent reply other threads:[~2016-03-15 9:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 9:29 [Qemu-devel] Our use of #include is undisciplined, and what to do about it Markus Armbruster
2016-03-15 9:40 ` Paolo Bonzini [this message]
2016-03-15 12:19 ` Markus Armbruster
2016-03-15 14:51 ` Paolo Bonzini
2016-03-15 10:03 ` Peter Maydell
2016-03-15 12:28 ` Markus Armbruster
2016-03-15 12:56 ` Peter Maydell
2016-03-15 13:39 ` Stefan Hajnoczi
2016-03-15 13:51 ` Daniel P. Berrange
2016-03-15 13:56 ` Dr. David Alan Gilbert
2016-03-16 18:23 ` Stefan Hajnoczi
2016-03-16 18:27 ` Dr. David Alan Gilbert
2016-03-17 11:25 ` Stefan Hajnoczi
2016-03-17 16:29 ` Dr. David Alan Gilbert
2016-03-17 19:21 ` Paolo Bonzini
2016-03-17 19:43 ` Dr. David Alan Gilbert
2016-03-17 19:58 ` Paolo Bonzini
2016-03-17 20:14 ` Richard Henderson
2016-03-17 20:27 ` Peter Maydell
2016-03-17 20:29 ` Richard Henderson
2016-03-17 21:02 ` Paolo Bonzini
2016-03-17 20:59 ` Paolo Bonzini
2016-03-17 19:40 ` Richard Henderson
2019-05-27 13:12 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E7D884.902@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).