From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afpjv-0000a8-OB for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:14:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afpjs-0008Kq-JM for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:14:27 -0400 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:38909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afpjs-0008Ki-Bi for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:14:24 -0400 Received: by mail-wm0-x22a.google.com with SMTP id l68so28595895wml.1 for ; Tue, 15 Mar 2016 07:14:24 -0700 (PDT) Sender: Paolo Bonzini References: <1458050002-27741-1-git-send-email-mst@redhat.com> From: Paolo Bonzini Message-ID: <56E818BD.2080906@redhat.com> Date: Tue, 15 Mar 2016 15:14:21 +0100 MIME-Version: 1.0 In-Reply-To: <1458050002-27741-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Corey Minyard , Gerd Hoffmann On 15/03/2016 14:55, Michael S. Tsirkin wrote: > Allowing arbitary file names on command line is setting us up for > failure: future guests will look for a specific QEMU-specified name and > will get confused finding a user file there. > > Signed-off-by: Michael S. Tsirkin Too bad for the user. I think we have already gone through this discussion. Paolo > --- > vl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/vl.c b/vl.c > index 7a28982..5654af6 100644 > --- a/vl.c > +++ b/vl.c > @@ -2321,6 +2321,7 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts, Error **errp) > if (strncmp(name, "opt/", 4) != 0) { > - error_report("warning: externally provided fw_cfg item names " > - "should be prefixed with \"opt/\""); > + error_report("externally provided fw_cfg item names " > + "must be prefixed with \"opt/\""); > + return -1; > } > if (nonempty_str(str)) { > size = strlen(str); /* NUL terminator NOT included in fw_cfg blob */ >