From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afqMu-0001MI-7s for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:54:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afqMp-0004UI-8L for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:54:44 -0400 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:38435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afqMp-0004UB-2N for qemu-devel@nongnu.org; Tue, 15 Mar 2016 10:54:39 -0400 Received: by mail-wm0-x236.google.com with SMTP id l68so30404033wml.1 for ; Tue, 15 Mar 2016 07:54:38 -0700 (PDT) Sender: Paolo Bonzini References: <1458050002-27741-1-git-send-email-mst@redhat.com> <56E818BD.2080906@redhat.com> <20160315161755-mutt-send-email-mst@redhat.com> From: Paolo Bonzini Message-ID: <56E8222C.7090909@redhat.com> Date: Tue, 15 Mar 2016 15:54:36 +0100 MIME-Version: 1.0 In-Reply-To: <20160315161755-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Corey Minyard , qemu-devel@nongnu.org, Gerd Hoffmann On 15/03/2016 15:25, Michael S. Tsirkin wrote: > Do you look at all warnings all your software prints? Yes. I also try to understand them, and if they seem useless I propose a patch upstream. > What if user uses some tool to build the command line? > > consider mem-path - for years we printed a warning if > it's not on hugetlbfs. It worked and users just ignored it. That was a bad warning though. There was no reason to warn. It was also the smallest problem with the original hugetlbfs patches. > So now Corey basically is prevented from sorting sanely > because command line might not start with opt/ Can you explain? Paolo