From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afrJU-0006Ga-M2 for qemu-devel@nongnu.org; Tue, 15 Mar 2016 11:55:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afrJO-0007ET-TV for qemu-devel@nongnu.org; Tue, 15 Mar 2016 11:55:16 -0400 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:34529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afrJO-0007EF-NS for qemu-devel@nongnu.org; Tue, 15 Mar 2016 11:55:10 -0400 Received: by mail-wm0-x231.google.com with SMTP id p65so151054315wmp.1 for ; Tue, 15 Mar 2016 08:55:10 -0700 (PDT) Sender: Paolo Bonzini References: <1458054221-16923-1-git-send-email-armbru@redhat.com> <1458054221-16923-15-git-send-email-armbru@redhat.com> From: Paolo Bonzini Message-ID: <56E8305B.2000300@redhat.com> Date: Tue, 15 Mar 2016 16:55:07 +0100 MIME-Version: 1.0 In-Reply-To: <1458054221-16923-15-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 15/03/2016 16:03, Markus Armbruster wrote: > diff --git a/include/hw/hw.h b/include/hw/hw.h > index 2cb69d5..151d65e 100644 > --- a/include/hw/hw.h > +++ b/include/hw/hw.h > @@ -15,6 +15,7 @@ > #include "qemu/module.h" > > #ifdef NEED_CPU_H > +#include "cpu.h" > #if TARGET_LONG_BITS == 64 > #define qemu_put_betl qemu_put_be64 > #define qemu_get_betl qemu_get_be64 This actually makes things somewhat worse. This dependency of hw/hw.h on NEED_CPU_H should go away altogether. Would it be okay to stick to patches 1-13 for now? Paolo