From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afrSF-0008Or-Ip for qemu-devel@nongnu.org; Tue, 15 Mar 2016 12:04:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afrSB-0002EI-H4 for qemu-devel@nongnu.org; Tue, 15 Mar 2016 12:04:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afrSB-0002EC-5S for qemu-devel@nongnu.org; Tue, 15 Mar 2016 12:04:15 -0400 References: <1458054221-16923-1-git-send-email-armbru@redhat.com> <1458054221-16923-2-git-send-email-armbru@redhat.com> From: Paolo Bonzini Message-ID: <56E8327B.1090002@redhat.com> Date: Tue, 15 Mar 2016 17:04:11 +0100 MIME-Version: 1.0 In-Reply-To: <1458054221-16923-2-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/15] include/qemu/osdep.h: Don't include qapi/error.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 15/03/2016 16:03, Markus Armbruster wrote: > diff --git a/include/ui/qemu-spice.h b/include/ui/qemu-spice.h > index 2dabe49..904501a 100644 > --- a/include/ui/qemu-spice.h > +++ b/include/ui/qemu-spice.h > @@ -23,6 +23,7 @@ > > #include > > +#include "qapi/error.h" > #include "qemu/option.h" > #include "qemu/config-file.h" > This must be moved outside the #ifdef CONFIG_SPICE, because ui/qemu-spice.h uses error_set call outside that #ifdef. Paolo