From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afsiq-0008Mi-O7 for qemu-devel@nongnu.org; Tue, 15 Mar 2016 13:25:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afsin-0000aM-GI for qemu-devel@nongnu.org; Tue, 15 Mar 2016 13:25:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afsin-0000aB-Av for qemu-devel@nongnu.org; Tue, 15 Mar 2016 13:25:29 -0400 References: <1458054221-16923-1-git-send-email-armbru@redhat.com> <1458054221-16923-15-git-send-email-armbru@redhat.com> <56E8305B.2000300@redhat.com> <87r3fbsnxb.fsf@blackfin.pond.sub.org> From: Paolo Bonzini Message-ID: <56E84585.9020401@redhat.com> Date: Tue, 15 Mar 2016 18:25:25 +0100 MIME-Version: 1.0 In-Reply-To: <87r3fbsnxb.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On 15/03/2016 17:31, Markus Armbruster wrote: > Paolo Bonzini writes: >=20 >> On 15/03/2016 16:03, Markus Armbruster wrote: >>> diff --git a/include/hw/hw.h b/include/hw/hw.h >>> index 2cb69d5..151d65e 100644 >>> --- a/include/hw/hw.h >>> +++ b/include/hw/hw.h >>> @@ -15,6 +15,7 @@ >>> #include "qemu/module.h" >>> =20 >>> #ifdef NEED_CPU_H >>> +#include "cpu.h" >>> #if TARGET_LONG_BITS =3D=3D 64 >>> #define qemu_put_betl qemu_put_be64 >>> #define qemu_get_betl qemu_get_be64 >> >> This actually makes things somewhat worse. This dependency of hw/hw.h >> on NEED_CPU_H should go away altogether. >> >> Would it be okay to stick to patches 1-13 for now? >=20 > Yes, as long as "for now" approximately means "until 2.7 opens up". >=20 > Proposed plan: I pursue 01-13 now, you rebase your need-cpu-h branch > onto this work when it's ready, I rebase 14-15 onto yours, and carry on= . > Makes sense? Yes, totally. I've already started rebasing and there's nothing else that sticks out. Since I have your attention, what about getting rid of fprintf-fn.h and moving it into qemu/osdep.h? Paolo