From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54558)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1afslI-000281-1O
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 13:28:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1afslE-000189-Nz
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 13:28:03 -0400
Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:38437)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1afslE-00017j-GU
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 13:28:00 -0400
Received: by mail-wm0-x236.google.com with SMTP id l68so37001265wml.1
	for <qemu-devel@nongnu.org>; Tue, 15 Mar 2016 10:28:00 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1457869229-9989-1-git-send-email-marcel@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56E8461C.6030306@redhat.com>
Date: Tue, 15 Mar 2016 18:27:56 +0100
MIME-Version: 1.0
In-Reply-To: <1457869229-9989-1-git-send-email-marcel@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/acpi: fix GSI links UID
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel@redhat.com>, qemu-devel@nongnu.org
Cc: imammedo@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mst@redhat.com



On 13/03/2016 12:40, Marcel Apfelbaum wrote:
> According to the ACPI spec, each UID must be unique.
> Use the irq number as UID for GSI links.
> 
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>

This causes a warning from acpi-test.  The diff is

2720c2720
<             Name (_UID, Zero)  // _UID: Unique ID
---
>             Name (_UID, 0x10)  // _UID: Unique ID
2747c2747
<             Name (_UID, Zero)  // _UID: Unique ID
---
>             Name (_UID, 0x11)  // _UID: Unique ID
2774c2774
<             Name (_UID, Zero)  // _UID: Unique ID
---
>             Name (_UID, 0x12)  // _UID: Unique ID
2801c2801
<             Name (_UID, Zero)  // _UID: Unique ID
---
>             Name (_UID, 0x13)  // _UID: Unique ID
2828c2828
<             Name (_UID, Zero)  // _UID: Unique ID
---
>             Name (_UID, 0x14)  // _UID: Unique ID
2855c2855
<             Name (_UID, Zero)  // _UID: Unique ID
---
>             Name (_UID, 0x15)  // _UID: Unique ID
2882c2882
<             Name (_UID, Zero)  // _UID: Unique ID
---
>             Name (_UID, 0x16)  // _UID: Unique ID
2909c2909
<             Name (_UID, Zero)  // _UID: Unique ID
---
>             Name (_UID, 0x17)  // _UID: Unique ID

I think you should have updated tests/acpi-test-data.

Paolo