From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aft1k-0002fQ-F0 for qemu-devel@nongnu.org; Tue, 15 Mar 2016 13:45:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aft1h-0006ha-AM for qemu-devel@nongnu.org; Tue, 15 Mar 2016 13:45:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aft1h-0006hD-4h for qemu-devel@nongnu.org; Tue, 15 Mar 2016 13:45:01 -0400 References: <1458054221-16923-1-git-send-email-armbru@redhat.com> <1458054221-16923-15-git-send-email-armbru@redhat.com> <56E8305B.2000300@redhat.com> <87r3fbsnxb.fsf@blackfin.pond.sub.org> <56E84585.9020401@redhat.com> From: Paolo Bonzini Message-ID: <56E84A18.7080803@redhat.com> Date: Tue, 15 Mar 2016 18:44:56 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Markus Armbruster , QEMU Developers On 15/03/2016 18:34, Peter Maydell wrote: >> > Since I have your attention, what about getting rid of fprintf-fn.h = and >> > moving it into qemu/osdep.h? > Not a lot very osdep-ish about it... If you're going to put it anywhere > then typedefs.h seems more appropriate. Well, osdep.h is the new qemu-common.h. At least it doesn't include other^Wtoo many other QEMU header files, but it does have a lot of prototypes that are even more out of place than fprintf_function. On the other hand, there are few enough headers that use fprintf-fn.h that it's feasible to just push it down from qemu-common.h. Paolo > (It's in its own file at the moment as part of a previous idea of > cleaning up qemu-common.h by splitting it into separate parts where > necessary so that only the needed parts could be included by the > code that wanted them.)