From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ag4sN-0004MI-4E for qemu-devel@nongnu.org; Wed, 16 Mar 2016 02:24:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ag4sI-0007PB-R8 for qemu-devel@nongnu.org; Wed, 16 Mar 2016 02:24:11 -0400 References: <1457974600-13828-1-git-send-email-clg@fr.ibm.com> <1457974600-13828-17-git-send-email-clg@fr.ibm.com> <20160316011446.GY9032@voom> From: Thomas Huth Message-ID: <56E8FC01.4040700@redhat.com> Date: Wed, 16 Mar 2016 07:24:01 +0100 MIME-Version: 1.0 In-Reply-To: <20160316011446.GY9032@voom> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oBHLDlFaJlo00GLa5eWus808bgC7ejj6L" Subject: Re: [Qemu-devel] [PATCH 16/17] ppc: Add dummy CIABR SPR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oBHLDlFaJlo00GLa5eWus808bgC7ejj6L Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 16.03.2016 02:14, David Gibson wrote: > On Mon, Mar 14, 2016 at 05:56:39PM +0100, C=C3=A9dric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> We should implement HW breakpoint/watchpoint, qemu supports them... >> >> Signed-off-by: Benjamin Herrenschmidt >=20 > Reviewed-by: David Gibson >=20 > But I'm assuming 2.7, not 2.6. Looks like this register can be set by the guest using the H_SET_MODE hypercall, too (search for H_SET_MODE_RESOURCE_SET_CIABR in the KVM kernel sources), similar to the DAWR register. And this patch is using KVM_REG_PPC_CIABR to link this register with the KVM code in the kernel ... so I think this patch should still go into 2.6 to make sure that the register is migrated properly. Thomas >> --- >> target-ppc/cpu.h | 1 + >> target-ppc/translate_init.c | 5 +++++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h >> index 5203cc6a3bfb..9e1ef10b7dc6 100644 >> --- a/target-ppc/cpu.h >> +++ b/target-ppc/cpu.h >> @@ -1400,6 +1400,7 @@ static inline int cpu_mmu_index (CPUPPCState *en= v, bool ifetch) >> #define SPR_DAWR (0x0B4) >> #define SPR_MPPR (0x0B8) >> #define SPR_RPR (0x0BA) >> +#define SPR_CIABR (0x0BB) >> #define SPR_DAWRX (0x0BC) >> #define SPR_HFSCR (0x0BE) >> #define SPR_VRSAVE (0x100) >> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c= >> index cfb1bc088950..f88bdf7b3cd1 100644 >> --- a/target-ppc/translate_init.c >> +++ b/target-ppc/translate_init.c >> @@ -7603,6 +7603,11 @@ static void gen_spr_book3s_207_dbg(CPUPPCState = *env) >> SPR_NOACCESS, SPR_NOACCESS, >> &spr_read_generic, &spr_write_generic, >> KVM_REG_PPC_DAWRX, 0x00000000); >> + spr_register_kvm_hv(env, SPR_CIABR, "CIABR", >> + SPR_NOACCESS, SPR_NOACCESS, >> + SPR_NOACCESS, SPR_NOACCESS, >> + &spr_read_generic, &spr_write_generic, >> + KVM_REG_PPC_CIABR, 0x00000000); >> } >> =20 >> static void gen_spr_970_dbg(CPUPPCState *env) >=20 --oBHLDlFaJlo00GLa5eWus808bgC7ejj6L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJW6PwBAAoJEC7Z13T+cC21XQMQAJ30P4JD++kK3BXFuACbJ4If l4CQmDn6+ib5iN73d9hq3iNiuGDy0vCWnePK4qCWs69fzeUePqiHVaDuDDcdmlTL 2TzkJJoNbGazW2vElSgxG8mqDQS96gOQR3AqEYFPipHjIn6SyJwere6C8XYsqGig mZkl0stRCTTUKNcgQCToUem410sGPv2jAZYnnGSxIHFfVzKEhWmmF4AfRePtzLzb BRjk1H3QPlThi7u8PPopx1CQ0w9u/JnylvJ6nAKiSowf3LWJO2pC0nCQh84Nhz6F ahEJfFc6x3DsuaYLQBRuo79r/etN/KkS5LLlFIG5Dq1FNLL98KTcEA5jLAKdmX3I OxzviV3Q/PHhPuXhR4+JqKf0M6B8SiVeaFGCS3bOfIhoO5SCjjvcpNZm2YkhONP9 UhAPFjGQsVgirNjzqbK2d23blAMBIU0VoXCLkbUZg7piSkgI3mKId/zYPGVljCQJ 4NYuTEflg61UtWdPmNgjTpJEHheV14/ZakJlR8/S2rKiVMRXFVAgbq+AnzkyZx35 +JqbbVRQ30+bbkQc7moabXUClPHNQM5A17oeB6bP9wn0VlUfLXQYMNviNP+jtWM4 zJyjmn3Qmi5cFK4F7r+z+wMPXy6jFvEHd8EkjmySGpgJ9NOgk+OiIT7lsLK7B9a+ LU46RjUef3bwOEDbWrD6 =sZIM -----END PGP SIGNATURE----- --oBHLDlFaJlo00GLa5eWus808bgC7ejj6L--