From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ag9Zo-0007C9-AE for qemu-devel@nongnu.org; Wed, 16 Mar 2016 07:25:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ag9Zj-0006a8-55 for qemu-devel@nongnu.org; Wed, 16 Mar 2016 07:25:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ag9Zj-0006Zx-0W for qemu-devel@nongnu.org; Wed, 16 Mar 2016 07:25:15 -0400 References: <1457954501-26528-1-git-send-email-den@openvz.org> <1457954501-26528-4-git-send-email-den@openvz.org> <56E6CAA9.9020908@redhat.com> <56E9418E.7080105@openvz.org> From: Paolo Bonzini Message-ID: <56E94296.9070003@redhat.com> Date: Wed, 16 Mar 2016 12:25:10 +0100 MIME-Version: 1.0 In-Reply-To: <56E9418E.7080105@openvz.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/9] log: improve code in do_qemu_set_log List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Dimitris Aragiorgis On 16/03/2016 12:20, Denis V. Lunev wrote: > The question here is the following actually. > > Should we continue to keep writing 'stderr' output to the log file > when we have cleared all log levels. If the answer is 'yes', > original == your code is correct while my is wrong. In the > other case - the situation becomes mirrored. You're right about the actual question to answer. I think the answer is yes, given the original purpose of Dimitris's patch. The behavior of "-daemonize -D foo" should be the same if QEMU is configured with or without the "log" trace backend. Paolo