From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41908)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1agAO2-0003sQ-7e
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 08:17:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1agANw-00076w-Ht
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 08:17:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58030)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1agANw-00076j-CJ
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 08:17:08 -0400
References: <1457869229-9989-1-git-send-email-marcel@redhat.com>
	<56E8461C.6030306@redhat.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <56E94EC0.1070809@redhat.com>
Date: Wed, 16 Mar 2016 14:17:04 +0200
MIME-Version: 1.0
In-Reply-To: <56E8461C.6030306@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/acpi: fix GSI links UID
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: imammedo@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mst@redhat.com

On 03/15/2016 07:27 PM, Paolo Bonzini wrote:
>
>
> On 13/03/2016 12:40, Marcel Apfelbaum wrote:
>> According to the ACPI spec, each UID must be unique.
>> Use the irq number as UID for GSI links.
>>
>> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
>> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
>
> This causes a warning from acpi-test.  The diff is
>
> 2720c2720
> <             Name (_UID, Zero)  // _UID: Unique ID
> ---
>>              Name (_UID, 0x10)  // _UID: Unique ID
> 2747c2747
> <             Name (_UID, Zero)  // _UID: Unique ID
> ---
>>              Name (_UID, 0x11)  // _UID: Unique ID
> 2774c2774
> <             Name (_UID, Zero)  // _UID: Unique ID
> ---
>>              Name (_UID, 0x12)  // _UID: Unique ID
> 2801c2801
> <             Name (_UID, Zero)  // _UID: Unique ID
> ---
>>              Name (_UID, 0x13)  // _UID: Unique ID
> 2828c2828
> <             Name (_UID, Zero)  // _UID: Unique ID
> ---
>>              Name (_UID, 0x14)  // _UID: Unique ID
> 2855c2855
> <             Name (_UID, Zero)  // _UID: Unique ID
> ---
>>              Name (_UID, 0x15)  // _UID: Unique ID
> 2882c2882
> <             Name (_UID, Zero)  // _UID: Unique ID
> ---
>>              Name (_UID, 0x16)  // _UID: Unique ID
> 2909c2909
> <             Name (_UID, Zero)  // _UID: Unique ID
> ---
>>              Name (_UID, 0x17)  // _UID: Unique ID
>
> I think you should have updated tests/acpi-test-data.

Thanks Paolo, you are right.

I am "used to" Michael updating the test data on his pull request.
I can send an update myself, it will have to wait a few days.

Thanks,
Marcel

>
> Paolo
>