From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55898)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1agBJ4-0007Lf-R4
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 09:16:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1agBIz-00057G-2Y
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 09:16:10 -0400
References: <1458123018-18651-1-git-send-email-famz@redhat.com>
	<56E9355A.5070700@redhat.com> <56E93A22.1080102@de.ibm.com>
	<56E93ECE.10103@redhat.com>
	<20160316123213.3dcf0abc.cornelia.huck@de.ibm.com>
	<56E94806.7060505@redhat.com>
	<20160316125623.38ab4c7e.cornelia.huck@de.ibm.com>
	<56E94AA9.8000803@redhat.com>
	<20160316132212.674f766f.cornelia.huck@de.ibm.com>
	<56E9527B.9010001@redhat.com>
	<20160316134257.72d7da56.cornelia.huck@de.ibm.com>
	<56E95646.8020802@redhat.com>
	<20160316140458.44dcd97d.cornelia.huck@de.ibm.com>
	<56E95B45.7060807@redhat.com>
	<20160316141450.7aa1cbcd.cornelia.huck@de.ibm.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56E95C8B.6070508@redhat.com>
Date: Wed, 16 Mar 2016 14:15:55 +0100
MIME-Version: 1.0
In-Reply-To: <20160316141450.7aa1cbcd.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Christian Borntraeger <borntraeger@de.ibm.com>, tubo@linux.vnet.ibm.com, Stefan Hajnoczi <stefanha@redhat.com>



On 16/03/2016 14:14, Cornelia Huck wrote:
> > And full of duplicate code.  If copied code were moved to the virtio bus
> > level, it would be easier to change too.
> 
> Yes, pci, ccw and mmio basically all do the same things. The only
> difference is actually wiring up the eventfd.
> 
> I can attempt to do some refactoring.

That would be great, in the meanwhile I've asked Christian to try
removing the calls that cause the reentrancy.

Paolo