From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agBlz-0008Rd-Ci for qemu-devel@nongnu.org; Wed, 16 Mar 2016 09:46:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agBlu-0004qx-Df for qemu-devel@nongnu.org; Wed, 16 Mar 2016 09:46:03 -0400 References: <1458123018-18651-1-git-send-email-famz@redhat.com> <56E9355A.5070700@redhat.com> <56E93A22.1080102@de.ibm.com> <56E93ECE.10103@redhat.com> <56E9425C.8030201@de.ibm.com> <56E957AD.2050005@redhat.com> <56E961EA.4090908@de.ibm.com> From: Paolo Bonzini Message-ID: <56E9638B.5090204@redhat.com> Date: Wed, 16 Mar 2016 14:45:47 +0100 MIME-Version: 1.0 In-Reply-To: <56E961EA.4090908@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, "Michael S. Tsirkin" , tubo@linux.vnet.ibm.com, Stefan Hajnoczi , cornelia.huck@de.ibm.com On 16/03/2016 14:38, Christian Borntraeger wrote: > > If you just remove the calls to virtio_queue_host_notifier_read, here > > and in virtio_queue_aio_set_host_notifier_fd_handler, does it work > > (keeping patches 2-4 in)? > > With these changes and patch 2-4 it does no longer locks up. > I keep it running some hour to check if a crash happens. > > Tu Bo, your setup is currently better suited for reproducing. Can you also check? Great, I'll prepare a patch to virtio then sketching the solution that Conny agreed with. While Fam and I agreed that patch 1 is not required, I'm not sure if the mutex is necessary in the end. So if Tu Bo can check without the virtio_queue_host_notifier_read calls, and both with/without Fam's patches, it would be great. Paolo