From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agEKr-0008CF-P9 for qemu-devel@nongnu.org; Wed, 16 Mar 2016 12:30:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agEKo-00037k-Vv for qemu-devel@nongnu.org; Wed, 16 Mar 2016 12:30:13 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:36203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agEKo-00037g-Pk for qemu-devel@nongnu.org; Wed, 16 Mar 2016 12:30:10 -0400 Received: by mail-wm0-x241.google.com with SMTP id l68so9469254wml.3 for ; Wed, 16 Mar 2016 09:30:10 -0700 (PDT) Sender: Paolo Bonzini References: <1458120244-30976-1-git-send-email-zxq_yx_007@163.com> <1458120244-30976-5-git-send-email-zxq_yx_007@163.com> From: Paolo Bonzini Message-ID: <56E98A10.6070809@redhat.com> Date: Wed, 16 Mar 2016 17:30:08 +0100 MIME-Version: 1.0 In-Reply-To: <1458120244-30976-5-git-send-email-zxq_yx_007@163.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] hw/audio: QOM'ify milkymist-ac97.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: xiaoqiang zhao , qemu-devel@nongnu.org Cc: michael@walle.cc, kraxel@redhat.com, afaerber@suse.de On 16/03/2016 10:24, xiaoqiang zhao wrote: > s->voice_out = AUD_open_out(&s->card, s->voice_out, > "mm_ac97.out", s, ac97_out_cb, &as); > AUD_open_out should not be done before realize. Paolo