From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60978)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zxq_yx_007@163.com>) id 1agMw7-0002e9-RQ
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 21:41:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zxq_yx_007@163.com>) id 1agMw3-0001JH-Oh
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 21:41:15 -0400
Received: from m12-14.163.com ([220.181.12.14]:38419)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zxq_yx_007@163.com>) id 1agMw3-0001IE-8j
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 21:41:11 -0400
References: <1458120244-30976-1-git-send-email-zxq_yx_007@163.com>
	<1458120244-30976-5-git-send-email-zxq_yx_007@163.com>
	<56E98A10.6070809@redhat.com>
From: xiaoqiang zhao <zxq_yx_007@163.com>
Message-ID: <56EA0AE7.7070607@163.com>
Date: Thu, 17 Mar 2016 09:39:51 +0800
MIME-Version: 1.0
In-Reply-To: <56E98A10.6070809@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 4/4] hw/audio: QOM'ify milkymist-ac97.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: michael@walle.cc, kraxel@redhat.com, afaerber@suse.de



在 2016年03月17日 00:30, Paolo Bonzini 写道:
>
> On 16/03/2016 10:24, xiaoqiang zhao wrote:
>>       s->voice_out = AUD_open_out(&s->card, s->voice_out,
>>               "mm_ac97.out", s, ac97_out_cb, &as);
>>   
> AUD_open_out should not be done before realize.
>
> Paolo
I wil move it to DeviceClasss::realize in the  next version.
Thank you Paolo !