From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, Gabriel Somlo <somlo@cmu.edu>
Cc: mark.rutland@arm.com, peter.maydell@linaro.org,
matt@codeblueprint.co.uk, stefanha@gmail.com,
qemu-devel@nongnu.org, eric@anholt.net, kraxel@redhat.com,
linux-api@vger.kernel.org, agross@codeaurora.org,
pawel.moll@arm.com, zajec5@gmail.com,
rmk+kernel@arm.linux.org.uk, lersek@redhat.com,
devicetree@vger.kernel.org, ehabkost@redhat.com, arnd@arndb.de,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
leif.lindholm@linaro.org, robh+dt@kernel.org, rth@twiddle.net,
ard.biesheuvel@linaro.org, Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, luto@amacapital.net,
hanjun.guo@linaro.org, sudeep.holla@arm.com, imammedo@redhat.com,
revol@free.fr
Subject: Re: [Qemu-devel] [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access
Date: Thu, 17 Mar 2016 14:13:54 +0100 [thread overview]
Message-ID: <56EAAD92.10007@redhat.com> (raw)
In-Reply-To: <20160316185440-mutt-send-email-mst@redhat.com>
On 16/03/2016 17:57, Michael S. Tsirkin wrote:
> On Tue, Mar 08, 2016 at 01:30:50PM -0500, Gabriel Somlo wrote:
>> Allowing for the future possibility of implementing AML-based
>> (i.e., firmware-triggered) access to the QEMU fw_cfg device,
>> acquire the global ACPI lock when accessing the device on behalf
>> of the guest-side sysfs driver, to prevent any potential race
>> conditions.
>>
>> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
>> Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
>
> So this patch makes sense of course.
>
>
> Given the recent discussion on QEMU mailing list,
> I think there is an additional patch that we need:
> filter the files exposed to userspace by "opt/" prefix.
>
> This will ensure that we can change all other fw cfg files
> at will without breaking guest scripts.
That makes no sense, all other fw_cfg files are firmware ABI so we
cannot change them anyway.
Paolo
next prev parent reply other threads:[~2016-03-17 13:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 18:30 [Qemu-devel] [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access Gabriel Somlo
2016-03-09 9:13 ` Michael S. Tsirkin
2016-03-16 16:57 ` Michael S. Tsirkin
2016-03-17 13:13 ` Paolo Bonzini [this message]
2016-03-17 13:33 ` Gabriel L. Somlo
2016-03-17 14:03 ` Michael S. Tsirkin
2016-04-05 8:54 ` Michael S. Tsirkin
2016-04-11 13:13 ` Gabriel L. Somlo
2016-04-11 13:48 ` Michael S. Tsirkin
2016-04-03 12:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EAAD92.10007@redhat.com \
--to=pbonzini@redhat.com \
--cc=agross@codeaurora.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=ehabkost@redhat.com \
--cc=eric@anholt.net \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=hanjun.guo@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=leif.lindholm@linaro.org \
--cc=lersek@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=mst@redhat.com \
--cc=pawel.moll@arm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=revol@free.fr \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robh+dt@kernel.org \
--cc=rth@twiddle.net \
--cc=somlo@cmu.edu \
--cc=stefanha@gmail.com \
--cc=sudeep.holla@arm.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).