From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agdhm-0004jh-Gb for qemu-devel@nongnu.org; Thu, 17 Mar 2016 15:35:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agdhg-00041X-U3 for qemu-devel@nongnu.org; Thu, 17 Mar 2016 15:35:34 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:34511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agdhg-00041Q-Ms for qemu-devel@nongnu.org; Thu, 17 Mar 2016 15:35:28 -0400 Received: by mail-wm0-x242.google.com with SMTP id p65so1568076wmp.1 for ; Thu, 17 Mar 2016 12:35:28 -0700 (PDT) Sender: Paolo Bonzini References: <1458053080-29170-1-git-send-email-mst@redhat.com> <87fuvpv2jv.fsf@blackfin.pond.sub.org> <20160317143531-mutt-send-email-mst@redhat.com> <56EAB17A.1000400@redhat.com> <1458235026.26199.45.camel@redhat.com> From: Paolo Bonzini Message-ID: <56EB06FD.1060603@redhat.com> Date: Thu, 17 Mar 2016 20:35:25 +0100 MIME-Version: 1.0 In-Reply-To: <1458235026.26199.45.camel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: "Gabriel L. Somlo" , "Michael S. Tsirkin" , Laszlo Ersek , qemu-devel@nongnu.org, Markus Armbruster On 17/03/2016 18:17, Gerd Hoffmann wrote: > Hi, > >> Alternative: fail on: >> >> - a blacklist of etc/* files including etc/system-states, >> etc/smbios/smbios-tables, etc/smbios/smbios-anchor, >> etc/reserved-memory-end, etc/pvpanic-port, etc/e820, and possibly >> etc/boot-menu-wait > > I think that fails already because qemu throws an error on duplicate > firmware entries. The problem is that some files are only added conditionally (e.g. etc/boot-menu-wait). > Do we really want shuffle around stuff like this? It means we have to > support both paths in both firmware and qemu for a quite a while for > compatibility reasons. > > Also note that most stuff in etc/ is used by all firmwares, so moving > this to org.seabios looks pointless to me, especially as things might > change over time (i.e. ovmf starting to use cfg options it used to > ignore first, which is the case for etc/boot-menu-wait IIRC, so it > started as seabios only but isn't any more). Stuff that is used by all firmwares could move to org.coreboot/ or org.qemu/, but keeping etc/ as a special case is certainly fine by me. Paolo