From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agoKp-0002bS-PH for qemu-devel@nongnu.org; Fri, 18 Mar 2016 02:56:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agoKm-0001c2-KD for qemu-devel@nongnu.org; Fri, 18 Mar 2016 02:56:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agoKm-0001bq-E7 for qemu-devel@nongnu.org; Fri, 18 Mar 2016 02:56:32 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 729BCC049D5C for ; Fri, 18 Mar 2016 06:56:31 +0000 (UTC) References: <1458033424-25414-1-git-send-email-wexu@redhat.com> <1458033424-25414-2-git-send-email-wexu@redhat.com> <56EA6DE2.7070502@redhat.com> <56EADF28.3000101@redhat.com> <56EB61D8.8080202@redhat.com> <56EB816D.5000804@redhat.com> <56EB902F.1070506@redhat.com> <56EBA255.3090608@redhat.com> From: Jason Wang Message-ID: <56EBA69C.1090109@redhat.com> Date: Fri, 18 Mar 2016 14:56:28 +0800 MIME-Version: 1.0 In-Reply-To: <56EBA255.3090608@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [ Patch 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Xu , qemu-devel@nongnu.org On 03/18/2016 02:38 PM, Wei Xu wrote: > > > On 2016=E5=B9=B403=E6=9C=8818=E6=97=A5 13:20, Jason Wang wrote: >> >> On 03/18/2016 12:17 PM, Wei Xu wrote: >>>>>>> +static ssize_t virtio_net_receive(NetClientState *nc, >>>>>>> + const uint8_t *buf, size_t siz= e) >>>>>>> +{ >>>>>>> + if (virtio_net_rsc_bypass) { >>>>>>> + return virtio_net_do_receive(nc, buf, size); >>>>>> You need a feature bit for this and compat it for older machine >>>>>> types. >>>>>> And also need some work on virtio spec I think. >>>>> yes, not sure which way is good to support this, hmp/qmp/ethtool, >>>>> this >>>>> is gonna to support win guest, >>>>> so need a well-compatible interface, any comments? >>>> I think this should be implemented through feature bits/negotiation >>>> instead of something like ethtool. >>> Looks this feature should be turn on/off dynamically due to the spec, >>> so maybe this should be managed from the guest, is there any referenc= e >>> code for this? >> Then you may want to look at implementation of >> VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. > Have a short look at it, do you know how to control the feature bit?=20 > both when lauching vm and changing it during runtime?=20 Virtio spec and maybe windows driver source code can give you the answer.