From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35829)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1aguFk-00028n-9C
	for qemu-devel@nongnu.org; Fri, 18 Mar 2016 09:15:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1aguFe-0003ei-Jp
	for qemu-devel@nongnu.org; Fri, 18 Mar 2016 09:15:44 -0400
References: <1458130611-17304-1-git-send-email-thuth@redhat.com>
	<1458130611-17304-4-git-send-email-thuth@redhat.com>
From: Laurent Vivier <lvivier@redhat.com>
Message-ID: <56EBFF76.2070702@redhat.com>
Date: Fri, 18 Mar 2016 14:15:34 +0100
MIME-Version: 1.0
In-Reply-To: <1458130611-17304-4-git-send-email-thuth@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] hw/net/spapr_llan: Enable
 the RX buffer pools by default for new machines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>, Alexander Graf <agraf@suse.de>
Cc: Jason Wang <jasowang@redhat.com>, qemu-ppc@nongnu.org



On 16/03/2016 13:16, Thomas Huth wrote:
> RX buffer pools are now enabled by default for new machine types.
> For older machine types, they are still disabled to avoid breaking
> migration.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Laurent Vivier <lvivier@redhat.com>

> ---
>  hw/net/spapr_llan.c | 2 +-
>  hw/ppc/spapr.c      | 7 ++++++-
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/net/spapr_llan.c b/hw/net/spapr_llan.c
> index 74c8b1e..4e28b89 100644
> --- a/hw/net/spapr_llan.c
> +++ b/hw/net/spapr_llan.c
> @@ -709,7 +709,7 @@ static Property spapr_vlan_properties[] = {
>      DEFINE_SPAPR_PROPERTIES(VIOsPAPRVLANDevice, sdev),
>      DEFINE_NIC_PROPERTIES(VIOsPAPRVLANDevice, nicconf),
>      DEFINE_PROP_BIT("use-rx-buffer-pools", VIOsPAPRVLANDevice,
> -                    compat_flags, SPAPRVLAN_FLAG_RX_BUF_POOLS_BIT, false),
> +                    compat_flags, SPAPRVLAN_FLAG_RX_BUF_POOLS_BIT, true),
>      DEFINE_PROP_END_OF_LIST(),
>  };
>  
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 79a70a9..50d5a62 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -2362,7 +2362,12 @@ DEFINE_SPAPR_MACHINE(2_6, "2.6", true);
>   * pseries-2.5
>   */
>  #define SPAPR_COMPAT_2_5 \
> -        HW_COMPAT_2_5
> +    HW_COMPAT_2_5 \
> +    { \
> +        .driver   = "spapr-vlan", \
> +        .property = "use-rx-buffer-pools", \
> +        .value    = "off", \
> +    },
>  
>  static void spapr_machine_2_5_instance_options(MachineState *machine)
>  {
>