From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58312)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jgross@suse.com>) id 1agvgF-0004vi-44
	for qemu-devel@nongnu.org; Fri, 18 Mar 2016 10:47:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jgross@suse.com>) id 1agvgB-0006Js-95
	for qemu-devel@nongnu.org; Fri, 18 Mar 2016 10:47:11 -0400
Received: from mx2.suse.de ([195.135.220.15]:60413)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jgross@suse.com>) id 1agvgB-0006J8-2C
	for qemu-devel@nongnu.org; Fri, 18 Mar 2016 10:47:07 -0400
References: <1457623170-30896-1-git-send-email-jgross@suse.com>
	<1458305544.6882.50.camel@redhat.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <56EC14E8.40103@suse.com>
Date: Fri, 18 Mar 2016 15:47:04 +0100
MIME-Version: 1.0
In-Reply-To: <1458305544.6882.50.camel@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb, xen: add pvUSB backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, konrad.wilk@oracle.com, stefano.stabellini@eu.citrix.com

On 18/03/16 13:52, Gerd Hoffmann wrote:
> On Do, 2016-03-10 at 16:19 +0100, Juergen Gross wrote:
>> This series adds a Xen pvUSB backend driver to qemu. USB devices
>> connected to the host can be passed through to a Xen guest. The
>> devices are specified via Xenstore. Access to the devices is done
>> via host-libusb.c
> 
>> I've tested the backend with various USB devices (memory sticks,
>> keyboard, ...).
> 
> Patches look sane to me.
> 
> Have you tested both virtual and physical devices?  Given how it is
> written devices such as the virtual usb tablet should work just fine
> too.

I tested with physical devices only.

TBH, I don't think a virtual device would work, given how the to be used
device is selected (driver="usb-host", hostbus, hostport).

> I can take that through the usb queue, but I'd like to see someone from
> xen have a look at this too.  Reviews anyone?

Awesome, thanks for the thumbs up!


Juergen