From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai0Jk-0000uT-CW for qemu-devel@nongnu.org; Mon, 21 Mar 2016 09:56:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai0Jh-0004uM-6I for qemu-devel@nongnu.org; Mon, 21 Mar 2016 09:56:24 -0400 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:38005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai0Jg-0004u9-Vv for qemu-devel@nongnu.org; Mon, 21 Mar 2016 09:56:21 -0400 Received: by mail-wm0-x234.google.com with SMTP id l68so122942212wml.1 for ; Mon, 21 Mar 2016 06:56:20 -0700 (PDT) Sender: Paolo Bonzini References: From: Paolo Bonzini Message-ID: <56EFFD82.5040404@redhat.com> Date: Mon, 21 Mar 2016 14:56:18 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Query about BiteSizeTasks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: haris iqbal , qemu-devel@nongnu.org On 21/03/2016 14:41, haris iqbal wrote: > Hello, > > I saw a task which says to " Add checks for NULL return value to uses > of load_image_targphys,...". But what I saw in the codebase, > load_image_targphys() returns int. So why should it be checks for > NULL. You're right, in the case of load_image_targphys the error value is -1. I've fixed the wiki page. Paolo