[Qemu-devel] Query about BiteSizeTasks

[Qemu-devel] Query about BiteSizeTasks

[haris iqbal]

Hello,

I saw a task which says to " Add checks for NULL return value to uses
of load_image_targphys,...". But what I saw in the codebase,
load_image_targphys() returns int. So why should it be checks for
NULL.

NULL check is for pointer which can also be changed to (void *)0.

Should the return value be checked for 0. But when I saw what the
function is doing, it basically is what lseek will return in
get_image_size() and lseek return (off_t)-1 if it fails.

-- 

With regards,

Md Haris Iqbal,
Placement Coordinator, MTech IT
NITK Surathkal,
Contact: +91 8861996962

Re: [Qemu-devel] Query about BiteSizeTasks

[Paolo Bonzini]

On 21/03/2016 14:41, haris iqbal wrote:
> Hello,
> 
> I saw a task which says to " Add checks for NULL return value to uses
> of load_image_targphys,...". But what I saw in the codebase,
> load_image_targphys() returns int. So why should it be checks for
> NULL.

You're right, in the case of load_image_targphys the error value is -1.
 I've fixed the wiki page.

Paolo

Re: [Qemu-devel] Query about BiteSizeTasks

[haris iqbal]

On Mon, Mar 21, 2016 at 7:26 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 21/03/2016 14:41, haris iqbal wrote:
>> Hello,
>>
>> I saw a task which says to " Add checks for NULL return value to uses
>> of load_image_targphys,...". But what I saw in the codebase,
>> load_image_targphys() returns int. So why should it be checks for
>> NULL.
>
> You're right, in the case of load_image_targphys the error value is -1.
>  I've fixed the wiki page.


Thanks.

>
> Paolo



-- 

With regards,

Md Haris Iqbal,
Placement Coordinator, MTech IT
NITK Surathkal,
Contact: +91 8861996962

Re: [Qemu-devel] Query about BiteSizeTasks

[haris iqbal]

Hello,

One more thing I noticed was that there is no function prototype for
the function get_ticks_per_sec().

I was planning to use a script to change all the used of
get_ticks_per_sec() to NANOSECONDS_PER_SECOND with an exception of the
function definition itself in include/qemu/timer.h. SO wanted to know
if there is a function prototype that should also be skipped.

On Mon, Mar 21, 2016 at 7:39 PM, haris iqbal <haris.phnx@gmail.com> wrote:
> On Mon, Mar 21, 2016 at 7:26 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>>
>> On 21/03/2016 14:41, haris iqbal wrote:
>>> Hello,
>>>
>>> I saw a task which says to " Add checks for NULL return value to uses
>>> of load_image_targphys,...". But what I saw in the codebase,
>>> load_image_targphys() returns int. So why should it be checks for
>>> NULL.
>>
>> You're right, in the case of load_image_targphys the error value is -1.
>>  I've fixed the wiki page.
>
>
> Thanks.
>
>>
>> Paolo
>
>
>
> --
>
> With regards,
>
> Md Haris Iqbal,
> Placement Coordinator, MTech IT
> NITK Surathkal,
> Contact: +91 8861996962



-- 

With regards,

Md Haris Iqbal,
Placement Coordinator, MTech IT
NITK Surathkal,
Contact: +91 8861996962

Re: [Qemu-devel] Query about BiteSizeTasks

[Paolo Bonzini]

On 22/03/2016 05:34, haris iqbal wrote:
> Hello,
> 
> One more thing I noticed was that there is no function prototype for
> the function get_ticks_per_sec().
> 
> I was planning to use a script to change all the used of
> get_ticks_per_sec() to NANOSECONDS_PER_SECOND with an exception of the
> function definition itself in include/qemu/timer.h. SO wanted to know
> if there is a function prototype that should also be skipped.

A patch for this has already been posted, though it's not yet in qemu.git.

Paolo