From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai64T-0005wW-92 for qemu-devel@nongnu.org; Mon, 21 Mar 2016 16:05:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai64S-0008LK-1z for qemu-devel@nongnu.org; Mon, 21 Mar 2016 16:05:01 -0400 References: <1458569512-22970-1-git-send-email-berrange@redhat.com> <1458569512-22970-8-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <56F053E3.8070509@redhat.com> Date: Mon, 21 Mar 2016 14:04:51 -0600 MIME-Version: 1.0 In-Reply-To: <1458569512-22970-8-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9xIDX1c487trtrCPHt5I1vxTCXR3Q7r4n" Subject: Re: [Qemu-devel] [PATCH v6 07/11] block: move encryption deprecation warning into qcow code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9xIDX1c487trtrCPHt5I1vxTCXR3Q7r4n Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/21/2016 08:11 AM, Daniel P. Berrange wrote: > or a couple of releases we have been warning s/^or/For/ >=20 > Encrypted images are deprecated > Support for them will be removed in a future release. > You can use 'qemu-img convert' to convert your image to an unencrypte= d one. >=20 > This warning was issued by system emulators, qemu-img, qemu-nbd > and qemu-io. Such a broad warning was issued because the original > intention was to rip out all the code for dealing with encryption > inside the QEMU block layer APIs. >=20 > The new block encryption framework used for the LUKS driver does > not rely on the unloved block layer API for encryption keys, > instead using the QOM 'secret' object type. It is thus no longer > appropriate to warn about encryption unconditionally. >=20 > When the qcow/qcow2 drivers are converted to use the new encryption > framework too, it will be practical to keep AES-CBC support present > for use in qemu-img, qemu-io & qemu-nbd to allow for interoperability > with older QEMU versions and liberation of data from existing encrypted= > qcow2 files. >=20 > This change moves the warning out of the generic block code and > into the qcow/qcow2 drivers. Further, the warning is set to only > appear when running the system emulators, since qemu-img, qemu-io, > qemu-nbd are expected to support qcow2 encryption long term now that > the maint burden has been eliminated. >=20 > Signed-off-by: Daniel P. Berrange > --- > block.c | 12 +++++------- > block/qcow.c | 9 +++++++++ > block/qcow2.c | 8 ++++++++ > include/block/block.h | 1 + > tests/qemu-iotests/049.out | 6 ------ > tests/qemu-iotests/087 | 3 ++- > tests/qemu-iotests/087.out | 26 ++++++++------------------ > tests/qemu-iotests/134.out | 18 ------------------ > 8 files changed, 33 insertions(+), 50 deletions(-) >=20 With the typo fix, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9xIDX1c487trtrCPHt5I1vxTCXR3Q7r4n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW8FPjAAoJEKeha0olJ0Nq6/cIAK5DU/lE1EkjrTVZLNl33trs vcXHwsXfrPm07IxqA9mws3jqRvmV+trDo5IPh3Qq33i8j/rHJEWRhrSsyxpPjOSD NX+cDgDD3uoAJV4hZvmmjiwvr2A3xqBxdVoJyJ02f0qAxByaFFZSXuItMWokRIFe xm/OyyPf6nxzM9KnUzgYHK113WrpVf7OYnfBufE+4K3rESNBVgrR6FarNtCBUTh8 XNDY1vNuCFqJJLYJiNv9J5xobBnHisqiN/lJ6+8Qsn0nvfm6TXCIyfXzqi0YwIS5 QeUSMVMNbcSwTHeDzI4+WP+sqMCgKsekm2NVQv/V+NApg3MXIKzpmoF0zwOIbfs= =2+6I -----END PGP SIGNATURE----- --9xIDX1c487trtrCPHt5I1vxTCXR3Q7r4n--