From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai7lE-0000oO-JA for qemu-devel@nongnu.org; Mon, 21 Mar 2016 17:53:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai7lC-0003P0-Sw for qemu-devel@nongnu.org; Mon, 21 Mar 2016 17:53:16 -0400 References: <1458297067-19624-1-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <56F06D43.1080304@redhat.com> Date: Mon, 21 Mar 2016 15:53:07 -0600 MIME-Version: 1.0 In-Reply-To: <1458297067-19624-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IfCgMoL4Nok9qh7fFJ1IRht2QkED8G9fK" Subject: Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IfCgMoL4Nok9qh7fFJ1IRht2QkED8G9fK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/18/2016 04:31 AM, Kevin Wolf wrote: > The call in hmp_drive_del() is dead code because blk_remove_bs() is > called a few lines above. The only other remaining user is > bdrv_delete(), which only abuses bdrv_make_anon() to remove it from the= > named nodes list. This path inlines the list entry removal into > bdrv_delete() and removes bdrv_make_anon(). >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 15 +++------------ > blockdev.c | 3 --- > include/block/block.h | 1 - > 3 files changed, 3 insertions(+), 16 deletions(-) Nice diffstat, as well. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --IfCgMoL4Nok9qh7fFJ1IRht2QkED8G9fK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW8G1DAAoJEKeha0olJ0Nq9kEH/3f0IeIoNvRG1K2JlqDvovOD GJao8SSXQCHV2D3MIA6jr7hiKwkkKxOZwo2QGwb2mq/8t+GjzwBIboT8qxy2dTif pklZuWkG442cmaaN+Pof/zM/dxqgbCB7mbGv0e1vNqK7rwyxXXv0LJFwzhOBY0Qa Bwtdfza5bM4cCyS/HCr+g2N99iVO6PmjRQEvKag/B6LRJvZcQiQEbGOco5RTMsMv fS2WGyLU6szdy9tL9bc1Ose5OOViepk4RbsBYrwqbRqsgkVb+qBIifRJfusIU11Z H+wLVUSMRopEQGbbbK99xXzpQ9m3VMKORtjh/+AFNEt9DQAGSYlXU4o4Dd3cMhk= =Lk3P -----END PGP SIGNATURE----- --IfCgMoL4Nok9qh7fFJ1IRht2QkED8G9fK--