From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiG6l-00080H-Vt for qemu-devel@nongnu.org; Tue, 22 Mar 2016 02:48:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiG6i-0007lX-2u for qemu-devel@nongnu.org; Tue, 22 Mar 2016 02:48:03 -0400 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:33386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiG6g-0007lA-QF for qemu-devel@nongnu.org; Tue, 22 Mar 2016 02:48:00 -0400 Received: by mail-pf0-x244.google.com with SMTP id x3so34099735pfb.0 for ; Mon, 21 Mar 2016 23:47:58 -0700 (PDT) References: <1458546426-26222-1-git-send-email-aik@ozlabs.ru> <1458546426-26222-16-git-send-email-aik@ozlabs.ru> <20160322042017.GD23586@voom.redhat.com> From: Alexey Kardashevskiy Message-ID: <56F0EA97.2020802@ozlabs.ru> Date: Tue, 22 Mar 2016 17:47:51 +1100 MIME-Version: 1.0 In-Reply-To: <20160322042017.GD23586@voom.redhat.com> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH qemu v14 15/18] vfio: Add host side IOMMU capabilities List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Alex Williamson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 03/22/2016 03:20 PM, David Gibson wrote: > On Mon, Mar 21, 2016 at 06:47:03PM +1100, Alexey Kardashevskiy wrote: >> There are going to be multiple IOMMUs per a container. This moves >> the single host IOMMU parameter set to a list of VFIOHostIOMMU. >> >> This should cause no behavioral change and will be used later by >> the SPAPR TCE IOMMU v2 which will also add a vfio_host_iommu_del() helper. >> >> Signed-off-by: Alexey Kardashevskiy > > This looks ok except for the name. Calling each window a separate > "host IOMMU" is misleading. The different windows the container > supports might be implemented by different IOMMUs on the host side, or > it might be implemented by one IOMMU with multiple tables. > > Better to call them host DMA windows, or maybe container DMA windows. VFIOHostDMAWindow it is then. -- Alexey