From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiNnS-0001Pq-BL for qemu-devel@nongnu.org; Tue, 22 Mar 2016 11:00:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiNnP-0002of-0L for qemu-devel@nongnu.org; Tue, 22 Mar 2016 11:00:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiNnO-0002o4-JZ for qemu-devel@nongnu.org; Tue, 22 Mar 2016 11:00:34 -0400 References: <1458222382-6498-1-git-send-email-sergey.fedorov@linaro.org> <1458222382-6498-3-git-send-email-sergey.fedorov@linaro.org> <87d1qmsgmv.fsf@linaro.org> From: Paolo Bonzini Message-ID: <56F15E0D.5030104@redhat.com> Date: Tue, 22 Mar 2016 16:00:29 +0100 MIME-Version: 1.0 In-Reply-To: <87d1qmsgmv.fsf@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/5] tcg: reorganize tb_find_physical loop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , sergey.fedorov@linaro.org Cc: Sergey Fedorov , Peter Crosthwaite , qemu-devel@nongnu.org, Richard Henderson On 22/03/2016 15:59, Alex Benn=E9e wrote: >> > + for (ptb1 =3D &tcg_ctx.tb_ctx.tb_phys_hash[h]; >> > + (tb =3D *ptb1) !=3D NULL; >> > + ptb1 =3D &tb->phys_hash_next) { > I'm not sure I'm keen on the assignment in the for condition clause. I > appreciate the cleansing of the if !tb return exit though. Could we be > cleaner maybe? Here is my attempt: Sure, that would be just fine. Paolo