From: Thomas Huth <thuth@redhat.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
qemu-devel@nongnu.org, jan.kiszka@siemens.com
Subject: Re: [Qemu-devel] [PATCH] slirp: Fix memory leak on small incoming ipv4 packet
Date: Tue, 22 Mar 2016 16:39:14 +0100 [thread overview]
Message-ID: <56F16722.1020307@redhat.com> (raw)
In-Reply-To: <1458603985-10009-1-git-send-email-samuel.thibault@ens-lyon.org>
On 22.03.2016 00:46, Samuel Thibault wrote:
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> slirp/ip_input.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/slirp/ip_input.c b/slirp/ip_input.c
> index 12f173d..b464f6b 100644
> --- a/slirp/ip_input.c
> +++ b/slirp/ip_input.c
> @@ -85,7 +85,7 @@ ip_input(struct mbuf *m)
> DEBUG_ARG("m_len = %d", m->m_len);
>
> if (m->m_len < sizeof (struct ip)) {
> - return;
> + goto bad;
> }
>
> ip = mtod(m, struct ip *);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2016-03-22 15:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 23:46 [Qemu-devel] [PATCH] slirp: Fix memory leak on small incoming ipv4 packet Samuel Thibault
2016-03-22 15:39 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F16722.1020307@redhat.com \
--to=thuth@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).