From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55848)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1aiOOw-0008Oe-6R
	for qemu-devel@nongnu.org; Tue, 22 Mar 2016 11:39:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1aiOOr-00054G-83
	for qemu-devel@nongnu.org; Tue, 22 Mar 2016 11:39:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33529)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1aiOOr-00054B-2K
	for qemu-devel@nongnu.org; Tue, 22 Mar 2016 11:39:17 -0400
References: <1458603985-10009-1-git-send-email-samuel.thibault@ens-lyon.org>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <56F16722.1020307@redhat.com>
Date: Tue, 22 Mar 2016 16:39:14 +0100
MIME-Version: 1.0
In-Reply-To: <1458603985-10009-1-git-send-email-samuel.thibault@ens-lyon.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] slirp: Fix memory leak on small incoming
	ipv4 packet
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>, qemu-devel@nongnu.org, jan.kiszka@siemens.com

On 22.03.2016 00:46, Samuel Thibault wrote:
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
>  slirp/ip_input.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/slirp/ip_input.c b/slirp/ip_input.c
> index 12f173d..b464f6b 100644
> --- a/slirp/ip_input.c
> +++ b/slirp/ip_input.c
> @@ -85,7 +85,7 @@ ip_input(struct mbuf *m)
>  	DEBUG_ARG("m_len = %d", m->m_len);
>  
>  	if (m->m_len < sizeof (struct ip)) {
> -		return;
> +		goto bad;
>  	}
>  
>  	ip = mtod(m, struct ip *);
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>