* [Qemu-devel] [PATCH] slirp: Fix memory leak on small incoming ipv4 packet
@ 2016-03-21 23:46 Samuel Thibault
2016-03-22 15:39 ` Thomas Huth
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Thibault @ 2016-03-21 23:46 UTC (permalink / raw)
To: qemu-devel, jan.kiszka, thuth; +Cc: Samuel Thibault
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
slirp/ip_input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/slirp/ip_input.c b/slirp/ip_input.c
index 12f173d..b464f6b 100644
--- a/slirp/ip_input.c
+++ b/slirp/ip_input.c
@@ -85,7 +85,7 @@ ip_input(struct mbuf *m)
DEBUG_ARG("m_len = %d", m->m_len);
if (m->m_len < sizeof (struct ip)) {
- return;
+ goto bad;
}
ip = mtod(m, struct ip *);
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] slirp: Fix memory leak on small incoming ipv4 packet
2016-03-21 23:46 [Qemu-devel] [PATCH] slirp: Fix memory leak on small incoming ipv4 packet Samuel Thibault
@ 2016-03-22 15:39 ` Thomas Huth
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2016-03-22 15:39 UTC (permalink / raw)
To: Samuel Thibault, qemu-devel, jan.kiszka
On 22.03.2016 00:46, Samuel Thibault wrote:
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> slirp/ip_input.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/slirp/ip_input.c b/slirp/ip_input.c
> index 12f173d..b464f6b 100644
> --- a/slirp/ip_input.c
> +++ b/slirp/ip_input.c
> @@ -85,7 +85,7 @@ ip_input(struct mbuf *m)
> DEBUG_ARG("m_len = %d", m->m_len);
>
> if (m->m_len < sizeof (struct ip)) {
> - return;
> + goto bad;
> }
>
> ip = mtod(m, struct ip *);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-22 15:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-21 23:46 [Qemu-devel] [PATCH] slirp: Fix memory leak on small incoming ipv4 packet Samuel Thibault
2016-03-22 15:39 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).