From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiOVT-0007JY-PE for qemu-devel@nongnu.org; Tue, 22 Mar 2016 11:46:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiOVS-0007Gw-Qt for qemu-devel@nongnu.org; Tue, 22 Mar 2016 11:46:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiOVS-0007Gp-LW for qemu-devel@nongnu.org; Tue, 22 Mar 2016 11:46:06 -0400 References: <1458604039-10161-1-git-send-email-samuel.thibault@ens-lyon.org> From: Thomas Huth Message-ID: <56F168BC.2080208@redhat.com> Date: Tue, 22 Mar 2016 16:46:04 +0100 MIME-Version: 1.0 In-Reply-To: <1458604039-10161-1-git-send-email-samuel.thibault@ens-lyon.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] slirp: send icmp6 errors when UDP send failed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault , qemu-devel@nongnu.org, jan.kiszka@siemens.com On 22.03.2016 00:47, Samuel Thibault wrote: > Signed-off-by: Samuel Thibault > --- > slirp/udp6.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/slirp/udp6.c b/slirp/udp6.c > index 60a91c9..a23026f 100644 > --- a/slirp/udp6.c > +++ b/slirp/udp6.c > @@ -113,8 +113,7 @@ void udp6_input(struct mbuf *m) > m->m_data -= iphlen; > *ip = save_ip; > DEBUG_MISC((dfd, "udp tx errno = %d-%s\n", errno, strerror(errno))); > - /* TODO: ICMPv6 error */ > - /*icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));*/ > + icmp6_send_error(m, ICMP6_UNREACH, ICMP6_UNREACH_NO_ROUTE); > goto bad; > } > Reviewed-by: Thomas Huth