From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiR6a-0000VZ-Rb for qemu-devel@nongnu.org; Tue, 22 Mar 2016 14:32:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiR6a-0002oL-13 for qemu-devel@nongnu.org; Tue, 22 Mar 2016 14:32:36 -0400 References: <1458271654-23706-1-git-send-email-peterx@redhat.com> <1458271654-23706-2-git-send-email-peterx@redhat.com> From: Eric Blake Message-ID: <56F18FBC.3030909@redhat.com> Date: Tue, 22 Mar 2016 12:32:28 -0600 MIME-Version: 1.0 In-Reply-To: <1458271654-23706-2-git-send-email-peterx@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eh0QsTCkWo9UHfKBgwHFvKKJ7GV36fLoD" Subject: Re: [Qemu-devel] [PATCH v5 1/5] arm: qmp: add GICCapability struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: wei@redhat.com, peter.maydell@linaro.org, drjones@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, abologna@redhat.com, qemu-arm@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eh0QsTCkWo9UHfKBgwHFvKKJ7GV36fLoD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/17/2016 09:27 PM, Peter Xu wrote: > Define new struct to describe whether we support specific GIC version. >=20 > Signed-off-by: Peter Xu > --- > qapi-schema.json | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index f253a37..da9671a 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -4134,3 +4134,25 @@ > ## > { 'enum': 'ReplayMode', > 'data': [ 'none', 'record', 'play' ] } > + > +## > +# @GICCapability: > +# > +# This struct describes capability for a specific GIC version. These Might be nice to spell out what the acronym GIC means, but that's cosmeti= c. > +# bits are not only decided by QEMU/KVM software version, but also > +# decided by the hardware that the program is running upon. > +# > +# @version: version of GIC to be described. > +# > +# @emulated: whether current QEMU/hardware supports emulated GIC > +# device in user space. > +# > +# @kernel: whether current QEMU/hardware supports hardware > +# accelerated GIC device in kernel. > +# > +# Since: 2.6 > +## > +{ 'struct': 'GICCapability', > + 'data': { 'version': 'int', > + 'emulated': 'bool', > + 'kernel': 'bool' } } >=20 I might have squashed this with the patch that first uses GICCapability, as defining a type in isolation doesn't do much. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --eh0QsTCkWo9UHfKBgwHFvKKJ7GV36fLoD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW8Y+8AAoJEKeha0olJ0NqHtoH/AmFP67ZadpwoMGvNiaC4rLa l7SWA4/lZUFbbgDEygwa3A447LqUsXxGnQJDLRDvo/o7KrVyy5dSizzrbFscuGOk jwuSkhTnTMOPcEwm/sMYM+LRB7R5rQmIKhrXR7mp39Ugskz8HAREjnxf9G4aPrvD k4L0ATmAfoioepZ/2MrzrmgPq5+bDHxqpPstJvHEHhYbmXRZXPhwCXNx+WcKQxoi 2igvRJVf9Agg3CMQuxwCu6Yl02ov2ntwsDo6ynRUjTABe78pK8AH/FjIVFOKUvwO mUj8FzwamDwv/wtXITaJ5mqUYHpy3SDUru+k8wsumLzYnpJULi3PcbXsfzcE77w= =hRLg -----END PGP SIGNATURE----- --eh0QsTCkWo9UHfKBgwHFvKKJ7GV36fLoD--