From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiRGV-0006ym-CM for qemu-devel@nongnu.org; Tue, 22 Mar 2016 14:42:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiRGU-00066c-E9 for qemu-devel@nongnu.org; Tue, 22 Mar 2016 14:42:51 -0400 References: <1458271654-23706-1-git-send-email-peterx@redhat.com> <1458271654-23706-3-git-send-email-peterx@redhat.com> From: Eric Blake Message-ID: <56F19222.2050003@redhat.com> Date: Tue, 22 Mar 2016 12:42:42 -0600 MIME-Version: 1.0 In-Reply-To: <1458271654-23706-3-git-send-email-peterx@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Jl8GqSHPaVPdqK67oQPhUe2v045S9AH5L" Subject: Re: [Qemu-devel] [PATCH v5 2/5] arm: qmp: add query-gic-capabilities interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: wei@redhat.com, peter.maydell@linaro.org, drjones@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, abologna@redhat.com, qemu-arm@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Jl8GqSHPaVPdqK67oQPhUe2v045S9AH5L Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/17/2016 09:27 PM, Peter Xu wrote: > This patch adds the command "query-gic-capabilities" but not implemnet s/not implemnet/does not implement/ > it. The command is ARM-only. Return of the command is a list of > GICCapability struct that describes all GIC versions that current QEMU > and system support. >=20 > Signed-off-by: Peter Xu > --- > +++ b/qapi-schema.json > @@ -4156,3 +4156,14 @@ > 'data': { 'version': 'int', > 'emulated': 'bool', > 'kernel': 'bool' } } > + > +## > +# @query-gic-capabilities: > +# > +# Return a list of supported GIC version capabilities. > +# > +# Returns: a list of GICCapability. > +# > +# Since: 2.6 > +## > +{ 'command': 'query-gic-capabilities', 'returns': ['GICCapability'] } On the surface, this seems okay. As mentioned before, I would have squashed 1 and 2 into a single patch. The GICCapability type is extensible, and introspection is sufficient at seeing what the type is currently capable of exposing. On the other hand... > +++ b/scripts/qapi.py > @@ -46,6 +46,7 @@ returns_whitelist =3D [ > 'query-tpm-models', > 'query-tpm-types', > 'ringbuf-read', > + 'query-gic-capability', =2E..it required a whitelist, because you are violating the usual convention of returning a dict. If you DO need the whitelist, your addition should have been kept sorted. But you don't need it, if you would modify your QAPI to return a dict: { 'struct': 'GICCapabilitiesReturn', 'data': { 'capabilities': ['GICCapability'] } } { 'command': 'query-gic-capabilities', 'returns': 'GICCapabilitiesReturn' } Yes, the dict has only a single key, and that key points to the same list; but now you have future extensibility: in the future, we could return any future global data as a sibling to the array, without having to modify every element of the array to repeat redundant information. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Jl8GqSHPaVPdqK67oQPhUe2v045S9AH5L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW8ZIiAAoJEKeha0olJ0NqPWgIAJ3wmhWd1b5sTgWluBV3VBSm fBBJXL0dGAmAL2hOkDCzZ2EjeQpGY4+RqgjgGYAGgCCz8H33WX8dDo5NyuB7P0wl 5hrKJJ2z8i3/XEu3bl2ANPcVTRQT8jmG7bbm231n043NFAxMWrB1ufRrWgmJjtzX X9AxpEACbUWxkk+EZx33RpDYAxnCkw7FmTvSFSWmhlh/z8dl92hsQzLTmZzObEu2 f+r88F5jWeMTQnpi1d7LSoBXOSHPs2/deTtE3XFoDu9e2HzG8NufxuCwqZQOV+ys Cv4wsvEeGgW98wFC8qLmz5lQrGJR4umBXsL7TeHBL2vQTD/lZCIVyHPT0lEkgcg= =Hy/p -----END PGP SIGNATURE----- --Jl8GqSHPaVPdqK67oQPhUe2v045S9AH5L--