From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59663)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aiTp1-00016j-3p
	for qemu-devel@nongnu.org; Tue, 22 Mar 2016 17:26:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aiTox-0006kV-Tz
	for qemu-devel@nongnu.org; Tue, 22 Mar 2016 17:26:39 -0400
Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:35278)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aiTox-0006k2-KL
	for qemu-devel@nongnu.org; Tue, 22 Mar 2016 17:26:35 -0400
Received: by mail-wm0-x234.google.com with SMTP id l68so171130135wml.0
	for <qemu-devel@nongnu.org>; Tue, 22 Mar 2016 14:26:35 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1458656229-32043-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA-X=13wAVx_CFXCzrySDRrZ30wZaw69y1myatRq7qgg3A@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56F1B888.8070503@redhat.com>
Date: Tue, 22 Mar 2016 22:26:32 +0100
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-X=13wAVx_CFXCzrySDRrZ30wZaw69y1myatRq7qgg3A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 00/29] Miscellaneous changes for 2016-03-22
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>



On 22/03/2016 21:27, Peter Maydell wrote:
> 
> PPC64 Linux:
> 
> /home/pm215/qemu/hw/intc/openpic_kvm.c: In function 'kvm_openpic_realize':
> /home/pm215/qemu/hw/intc/openpic_kvm.c:207:9: error: implicit
> declaration of function 'error_setg'
> [-Werror=implicit-function-declaration]
>          error_setg(errp, "Kernel is lacking Device Control API");
>          ^
> 
> OSX:
> /Users/pm215/src/qemu-for-merges/hw/usb/dev-mtp.c:1354:13: warning:
> implicit declaration of function 'error_setg' is invalid in C99
> [-Wimplicit-function-declaration]
>             error_setg(errp, "usb-mtp: x-root property must be configured");
>             ^
> 
> /Users/pm215/src/qemu-for-merges/net/tap-bsd.c:75:9: warning: implicit
> declaration of function 'error_setg_errno' is invalid in C99
> [-Wimplicit-function-declaration]
>         error_setg_errno(errp, errno, "could not open %s", dname);
>         ^
> /Users/pm215/src/qemu-for-merges/net/tap-bsd.c:99:13: warning:
> implicit declaration of function 'error_setg' is invalid in C99
> [-Wimplicit-function-declaration]
>             error_setg(errp, "vnet_hdr=1 requested, but no kernel "
>             ^

OS X is not surprising, since I had to fix both Win32 and ARM builds
compared to Markus's original patch...  I thought I had covered all
files in PPC, but openpic slipped.

Paolo