From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiU81-0003bs-Fx for qemu-devel@nongnu.org; Tue, 22 Mar 2016 17:46:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiU80-0000Mn-JY for qemu-devel@nongnu.org; Tue, 22 Mar 2016 17:46:17 -0400 References: <1458660792-3035-1-git-send-email-kwolf@redhat.com> <1458660792-3035-3-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <56F1BD22.8020206@redhat.com> Date: Tue, 22 Mar 2016 15:46:10 -0600 MIME-Version: 1.0 In-Reply-To: <1458660792-3035-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lw84Mjx3Ohhc7vJlIt3dwLsPCdIdGCSOt" Subject: Re: [Qemu-devel] [PATCH 02/12] block: Make sure throttled BDSes always have a BB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lw84Mjx3Ohhc7vJlIt3dwLsPCdIdGCSOt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/22/2016 09:33 AM, Kevin Wolf wrote: > It was already true in principle that a throttled BDS always has a BB > attached, except that the order of operations while attaching or > detaching a BDS to/from a BB wasn't careful enough. >=20 > This commit breaks graph manipulations while I/O throttling is enabled.= > It would have been possible, but quite cumbersome, to keep things > working with some temporary hacks, so it's not worth the hassle. We'll > fix things again in a minute. Might read slightly better as: It would have been possible to keep things working with some temporary hacks, but quite cumbersome, so it's not worth the hassle. >=20 > Signed-off-by: Kevin Wolf > --- > +#if 0 > bdrv_io_limits_enable(bs_new, throttle_group_get_name(bs_top))= ; > bdrv_io_limits_disable(bs_top); > +#else > + abort(); If it weren't fixed in the same series, then I'd want some text to go along with the abort. But since it's temporary, this is fine. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lw84Mjx3Ohhc7vJlIt3dwLsPCdIdGCSOt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW8b0iAAoJEKeha0olJ0NqTDEIAIIy2i6RfjffMPrmGgr11qti 2ssV1Wi8QEqq5VaKUVRSotyCTpXfiECaFaIM/y47x+aUj+qFck2oQ38yJQFimb7o oFHZMo31Zxehxzzex6z3ZpDrT/ckBJFbE/4a6qXshd4Rl0k/Poi7TURzGWVKPG9t 7njgmXl4o4IG+N0M55WB9p65u2AlJxj/2kQakULHHnHumPFndnKZ07DVTk7J4pfL GVoq6YU5vicp1cFH/9+VdFlxfUmOcvJjq2dtQBMFjUBSc/MvFZPQqnadAT87sLsp io1X1aXOVGxl8TVmwYF/SiN2aoW+6Xjoim6soCCUU/XpYVXxpIY2zh3NEDdKpU8= =tTgb -----END PGP SIGNATURE----- --lw84Mjx3Ohhc7vJlIt3dwLsPCdIdGCSOt--