From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aifHB-00052V-M4 for qemu-devel@nongnu.org; Wed, 23 Mar 2016 05:40:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aifH7-00038F-LB for qemu-devel@nongnu.org; Wed, 23 Mar 2016 05:40:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aifH7-00038B-FK for qemu-devel@nongnu.org; Wed, 23 Mar 2016 05:40:25 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id D4F38C075651 for ; Wed, 23 Mar 2016 09:40:24 +0000 (UTC) References: <1456151945-11225-1-git-send-email-pbonzini@redhat.com> <1456151945-11225-4-git-send-email-pbonzini@redhat.com> <87k2kvzu0z.fsf@blackfin.pond.sub.org> <56F01F8A.2090902@redhat.com> <87shzj68n2.fsf@blackfin.pond.sub.org> <56F030B3.3070709@redhat.com> <87fuvj1ywx.fsf@blackfin.pond.sub.org> <20160322081910.GA4222@noname.redhat.com> <87d1qmreqz.fsf@blackfin.pond.sub.org> <56F1C220.4000705@redhat.com> <87wpotblh9.fsf@blackfin.pond.sub.org> From: Paolo Bonzini Message-ID: <56F26485.7050000@redhat.com> Date: Wed, 23 Mar 2016 10:40:21 +0100 MIME-Version: 1.0 In-Reply-To: <87wpotblh9.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , qemu-devel@nongnu.org, Max Reitz On 23/03/2016 10:18, Markus Armbruster wrote: >> In Kevin's idea there would be no ownership either way. Until then, I >> think my patch actually gets us closer to the ideal. > > I'm afraid it gets us closer to where we used to be six years ago :) > > Qdev drive properties used to point to a DriveInfo, and the DriveInfo > pointed to BlockDriverState. Commit f8b6cc0 cut out the DriveInfo > middleman. This was a tiny step towards DriveInfo-less blockdev-add. > > DriveInfo is legacy configuration. Tacking it to BlockBackend is simple > and convenient. If it ceases to be simple and convenient, we can try to > find another home. But it really has no life of its own! I disagree; the life of DriveInfo is exactly the same as the -drive QemuOpts. But anyway, with your idea of adding an unrealize callback to the drive properties, I can move the extra reference within the device. It should become cleaner. Paolo