From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: wei@redhat.com, peter.maydell@linaro.org, drjones@redhat.com,
libvir-list@redhat.com, mdroth@linux.vnet.ibm.com,
armbru@redhat.com, qemu-arm@nongnu.org, abologna@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6 3/4] kvm: add kvm_support_device() helper function
Date: Wed, 23 Mar 2016 15:28:28 +0300 [thread overview]
Message-ID: <56F28BEC.2070008@gmail.com> (raw)
In-Reply-To: <1458711153-15988-4-git-send-email-peterx@redhat.com>
On 23/03/16 08:32, Peter Xu wrote:
> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
> index 6695fa7..8738fa1 100644
> --- a/include/sysemu/kvm.h
> +++ b/include/sysemu/kvm.h
> @@ -306,6 +306,15 @@ void kvm_device_access(int fd, int group, uint64_t attr,
> */
> int kvm_create_device(KVMState *s, uint64_t type, bool test);
>
> +/**
> + * kvm_support_device - probe whether KVM support specific device
> + *
> + * @vmfd: The fd handler for VM
> + * @type: type of device
> + *
> + * @return: true if supported, otherwise false.
> + */
> +bool kvm_support_device(int vmfd, uint64_t type);
Why don't name the function like 'kvm_device_supported' to better express its predicative nature?
Kind regards,
Sergey
next prev parent reply other threads:[~2016-03-23 12:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 5:32 [Qemu-devel] [PATCH v6 0/4] ARM: add query-gic-capabilities SMP command Peter Xu
2016-03-23 5:32 ` [Qemu-devel] [PATCH v6 1/4] arm: qmp: add query-gic-capabilities interface Peter Xu
2016-03-23 5:32 ` [Qemu-devel] [PATCH v6 2/4] arm: enhance kvm_arm_create_scratch_host_vcpu Peter Xu
2016-03-23 12:24 ` [Qemu-devel] [Qemu-arm] " Sergey Fedorov
2016-03-23 14:53 ` Peter Xu
2016-03-23 5:32 ` [Qemu-devel] [PATCH v6 3/4] kvm: add kvm_support_device() helper function Peter Xu
2016-03-23 12:28 ` Sergey Fedorov [this message]
2016-03-23 14:56 ` Peter Xu
2016-03-23 15:03 ` Sergey Fedorov
2016-03-24 1:59 ` Peter Xu
2016-03-23 5:32 ` [Qemu-devel] [PATCH v6 4/4] arm: implement query-gic-capabilities Peter Xu
2016-03-23 12:33 ` [Qemu-devel] [Qemu-arm] " Sergey Fedorov
2016-03-24 2:20 ` Peter Xu
2016-03-23 5:57 ` [Qemu-devel] [PATCH v6 0/4] ARM: add query-gic-capabilities SMP command Peter Xu
2016-03-23 8:54 ` Andrea Bolognani
2016-03-23 9:17 ` Peter Xu
2016-03-23 10:32 ` Christoffer Dall
2016-03-23 11:34 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F28BEC.2070008@gmail.com \
--to=serge.fdrv@gmail.com \
--cc=abologna@redhat.com \
--cc=armbru@redhat.com \
--cc=drjones@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).