From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aim36-0007lG-G9 for qemu-devel@nongnu.org; Wed, 23 Mar 2016 12:54:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aim31-0008Kh-R4 for qemu-devel@nongnu.org; Wed, 23 Mar 2016 12:54:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aim31-0008Kd-LT for qemu-devel@nongnu.org; Wed, 23 Mar 2016 12:54:19 -0400 References: <20160314074429.4980.34777.stgit@PASHA-ISP> <20160314074436.4980.83856.stgit@PASHA-ISP> <20160323154510.GF4126@noname.redhat.com> From: Paolo Bonzini Message-ID: <56F2CA34.1090808@redhat.com> Date: Wed, 23 Mar 2016 17:54:12 +0100 MIME-Version: 1.0 In-Reply-To: <20160323154510.GF4126@noname.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 1/7] replay: character devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Pavel Dovgalyuk Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, igor.rubinov@gmail.com, mark.burton@greensocs.com, real@ispras.ru, hines@cert.org, qemu-devel@nongnu.org, maria.klimushenkova@ispras.ru, stefanha@redhat.com, batuzovk@ispras.ru, alex.bennee@linaro.org, fred.konrad@greensocs.com On 23/03/2016 16:45, Kevin Wolf wrote: > Am 14.03.2016 um 08:44 hat Pavel Dovgalyuk geschrieben: >> This patch implements record and replay of character devices. >> It records chardevs communication in replay mode. Recorded information >> include data read from backend and counter of bytes written >> from frontend to backend to preserve frontend internal state. >> If character device was configured through the command line in record mode, >> then in replay mode it should be also added to command line. Backend of >> the character device could be changed in replay mode. >> Replaying of devices that perform ioctl and get_msgfd operations is not >> supported. >> gdbstub which also acts as a backend is not recorded to allow controlling >> the replaying through gdb. Monitor backends are also not recorded. >> >> Signed-off-by: Pavel Dovgalyuk > > This patch contains three lines with trailing whitespace. (Didn't > actually check anything but what the patch touches, but git show marked > it in red, so I couldn't not notice this.) It's merged anyway now. :) Paolo