From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43114)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wei@redhat.com>) id 1aimMN-0001EY-9E
	for qemu-devel@nongnu.org; Wed, 23 Mar 2016 13:14:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wei@redhat.com>) id 1aimMM-0005O7-BT
	for qemu-devel@nongnu.org; Wed, 23 Mar 2016 13:14:19 -0400
References: <1458221140-15232-1-git-send-email-zhaoshenglong@huawei.com>
	<CAFEAcA_7ww3PBQ5Mf=ax69B2i6zOx4-pDaiEUVerGG5iru-pJg@mail.gmail.com>
From: Wei Huang <wei@redhat.com>
Message-ID: <56F2CEE2.7060903@redhat.com>
Date: Wed, 23 Mar 2016 12:14:10 -0500
MIME-Version: 1.0
In-Reply-To: <CAFEAcA_7ww3PBQ5Mf=ax69B2i6zOx4-pDaiEUVerGG5iru-pJg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] Add gpio_key and use it for ARM virt
	power button
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Shannon Zhao <zhaoshenglong@huawei.com>
Cc: "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Shannon Zhao <shannon.zhao@linaro.org>



On 03/23/2016 11:12 AM, Peter Maydell wrote:
> On 17 March 2016 at 13:25, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
>> From: Shannon Zhao <shannon.zhao@linaro.org>
>>
>> There is a problem for power button that it will not work if an early
>> system_powerdown request happens before guest gpio driver loads.
>>
>> Here we add the emulation of gpio_key and use it for ARM virt power
>> button.
> 
> I tweaked the type names to be 'gpio-key' rather than 'gpio_key',
> and added a comment to briefly describe what the device does:
> 
> + * Emulate a (human) keypress -- when the key is triggered by
> + * setting the incoming gpio line, the outbound irq line is
> + * raised for 100ms before being dropped again.
> 
> Applied to target-arm.next, thanks.

I didn't see the patch series until yesterday. So just to make it
complete, I did test it with both DT and ACPI modes. The patch seemed to
work as intended.

Tested-by: Wei Huang <wei@redhat.com>

Thanks,
-Wei


> 
> -- PMM
>