From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aip8H-0000HA-Ns for qemu-devel@nongnu.org; Wed, 23 Mar 2016 16:11:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aip8G-00084Q-TT for qemu-devel@nongnu.org; Wed, 23 Mar 2016 16:11:57 -0400 References: <1458297067-19624-1-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <56F2F883.7000505@redhat.com> Date: Wed, 23 Mar 2016 21:11:47 +0100 MIME-Version: 1.0 In-Reply-To: <1458297067-19624-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ulLeAOK0bkTnGgnVowlMBrEHsP4WJPE70" Subject: Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ulLeAOK0bkTnGgnVowlMBrEHsP4WJPE70 Content-Type: multipart/mixed; boundary="cHfdUQVNRLlPoROUubPcdLxRFMgrCCeTo" From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, qemu-devel@nongnu.org Message-ID: <56F2F883.7000505@redhat.com> Subject: Re: [PATCH] block: Remove bdrv_make_anon() References: <1458297067-19624-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1458297067-19624-1-git-send-email-kwolf@redhat.com> --cHfdUQVNRLlPoROUubPcdLxRFMgrCCeTo Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 18.03.2016 11:31, Kevin Wolf wrote: > The call in hmp_drive_del() is dead code because blk_remove_bs() is > called a few lines above. Ah, so that's why I didn't have it in v3. Thanks for solving that mystery for me. :-) > The only other remaining user is > bdrv_delete(), which only abuses bdrv_make_anon() to remove it from the= > named nodes list. This path inlines the list entry removal into > bdrv_delete() and removes bdrv_make_anon(). >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 15 +++------------ > blockdev.c | 3 --- > include/block/block.h | 1 - > 3 files changed, 3 insertions(+), 16 deletions(-) Reviewed-by: Max Reitz --cHfdUQVNRLlPoROUubPcdLxRFMgrCCeTo-- --ulLeAOK0bkTnGgnVowlMBrEHsP4WJPE70 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW8viDAAoJEDuxQgLoOKyten8H/AsmsQ7FncCVxCVz/Bn752/h oDNCTrvFA/yvtuupeoIuJ7WzTCoWKIw3vNZHE8fxmtsGAFj/L9A3o08taHmt4iSq +3eH68rY66hVIYThHXwKzZ+T14RgPhZpZugUCyEo0bf5ZTYJFYSftfpAItyVTcxS 7ZYPA+ajUIc2x5Jbtzek0nlifj0lWK9gyzGxCnpwl8/3bXuD6XfcrXAl8Z8v+k7J Glh3w/wX6fU5Ur1I2EIzdRuccxILQQYMVTq+foICKY9kQyPLHf15fr5+crlz4XOn yOX6ZM39n7L/3Da/pItRL3xL3Ah8/6B3vyJP6bJdxy5vtEPqncmQrSfjsbvOEfM= =X5gK -----END PGP SIGNATURE----- --ulLeAOK0bkTnGgnVowlMBrEHsP4WJPE70--