From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aipdg-00023z-Vd for qemu-devel@nongnu.org; Wed, 23 Mar 2016 16:44:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aipdg-0000gw-3L for qemu-devel@nongnu.org; Wed, 23 Mar 2016 16:44:24 -0400 References: <1458237102-16204-1-git-send-email-berrange@redhat.com> <1458237102-16204-7-git-send-email-berrange@redhat.com> <20160318120935.GB5515@noname.redhat.com> <20160318144542.GJ17895@redhat.com> <20160318151907.GD5515@noname.redhat.com> From: Eric Blake Message-ID: <56F3001E.60106@redhat.com> Date: Wed, 23 Mar 2016 14:44:14 -0600 MIME-Version: 1.0 In-Reply-To: <20160318151907.GD5515@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wRHrq0AmGuCGf0f7iXtccUfugCNRIMEF1" Subject: Re: [Qemu-devel] [PATCH v5 6/7] block: add generic full disk encryption driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , "Daniel P. Berrange" Cc: Fam Zheng , qemu-devel@nongnu.org, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wRHrq0AmGuCGf0f7iXtccUfugCNRIMEF1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/18/2016 09:19 AM, Kevin Wolf wrote: >>>> + ov =3D opts_visitor_new(opts); >>>> + >>>> + visit_start_struct(opts_get_visitor(ov), >>>> + "luks", NULL, 0, &local_err); >>> >>> As this refers to "luks" specifically, shouldn't it be inside the swi= tch >>> below? >> >> Or probably better if I just change it to "", since this parameter >> is not actually used in this context IIRC. >=20 > NULL then? It would be very obvious then if it were used against our > expectations. Yes, please. The QMP input visitor has a bug where passing non-NULL at the top-level visit can cause weird behavior with parsing an extra {}; I have patches to fix it, but in the meantime consistently passing NULL for the top-level visit is safest. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wRHrq0AmGuCGf0f7iXtccUfugCNRIMEF1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW8wAeAAoJEKeha0olJ0NqkUQH/1GjShlCSWEQNY+Sa8UHBB7J GekXGKkJctIZ2V8dw5qco79kuZ2o83kVWKEDcTBGOtv1SB7B9tpbRhdL3Wc0xdfP lHaZw6eynH8hIVdENMGJzLs55yteYuvpPSXGlL9xfUSDIgy4Crxleb/bnYeJSt/E dTtH6mE4JxOH4z2XvVwLwWTBzOJ1Ndplc2U+YM4voF1gZTNH6UwvHDEL+2UpZOVk vLN7wWpbYREeDtMxMoExBakCp/NKdcP/aXQ1i8jPP0UoxvZrYHf3asu8SIu8rboU MVgbFOSQ5HNdlWS734hIOKq6WdG/cuadaUIafKmyOcsYe1dY3tUFb08BTAG5avU= =MInp -----END PGP SIGNATURE----- --wRHrq0AmGuCGf0f7iXtccUfugCNRIMEF1--