From: Eric Blake <eblake@redhat.com>
To: Veronia <veroniabahaa@gmail.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] util: move declarations out of qemu-common.h
Date: Wed, 23 Mar 2016 18:17:09 -0600 [thread overview]
Message-ID: <56F33205.50905@redhat.com> (raw)
In-Reply-To: <20160320144301.GA5720@veronia-Lenovo-IdeaPad-S400>
[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]
On 03/20/2016 08:43 AM, Veronia wrote:
> move declarations out of qemu-common.h for functions declared in
> utils/ files: e.g. include/qemu/path.h for utils/path.c.
> move inline functions out of qemu-common.h and into new files (e.g.
> include/qemu/bcd.h)
>
> Signed-off-by: Veronia Bahaa<veronia@veroniabahaa@gmail.com>
Space before <. 'git commit -s' (or 'git commit --amend -s' on an
existing commit) will space things correctly if your ~/.gitconfig is
correct; if you are typing the S-o-b by hand, I recommend figuring out
how to get git to do it for you.
> ---
> 161 files changed, 439 insertions(+), 320 deletions(-)
> create mode 100644 include/qemu/bcd.h
> create mode 100644 include/qemu/cutils.h
> create mode 100644 include/qemu/help_option.h
> create mode 100644 include/qemu/id.h
> create mode 100644 include/qemu/path.h
> create mode 100644 include/qemu/unicode.h
This is a big patch. To make review easier, I highly suggest that you
repost this as a series of (at least) 6 patches, one per file (if any
one include file is huge, it might help to further break it down into
2-3 related functions per patch rather than all functions belonging to
the file).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-03-24 0:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 14:43 [Qemu-devel] [PATCH] util: move declarations out of qemu-common.h Veronia
2016-03-24 0:17 ` Eric Blake [this message]
2016-03-24 0:18 ` Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2016-03-20 17:16 veroniabahaa
2016-03-21 17:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F33205.50905@redhat.com \
--to=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=veroniabahaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).