From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aisxf-0000ER-DB for qemu-devel@nongnu.org; Wed, 23 Mar 2016 20:17:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aisxc-0007Na-7X for qemu-devel@nongnu.org; Wed, 23 Mar 2016 20:17:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aisxc-0007NW-2h for qemu-devel@nongnu.org; Wed, 23 Mar 2016 20:17:12 -0400 References: <20160320144301.GA5720@veronia-Lenovo-IdeaPad-S400> From: Eric Blake Message-ID: <56F33205.50905@redhat.com> Date: Wed, 23 Mar 2016 18:17:09 -0600 MIME-Version: 1.0 In-Reply-To: <20160320144301.GA5720@veronia-Lenovo-IdeaPad-S400> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GBw4nCSef42QhKgQMURKECG9W9LRBkCrP" Subject: Re: [Qemu-devel] [PATCH] util: move declarations out of qemu-common.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Veronia , qemu-devel@nongnu.org Cc: pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GBw4nCSef42QhKgQMURKECG9W9LRBkCrP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/20/2016 08:43 AM, Veronia wrote: > move declarations out of qemu-common.h for functions declared in > utils/ files: e.g. include/qemu/path.h for utils/path.c. > move inline functions out of qemu-common.h and into new files (e.g. > include/qemu/bcd.h) >=20 > Signed-off-by: Veronia Bahaa Space before <. 'git commit -s' (or 'git commit --amend -s' on an existing commit) will space things correctly if your ~/.gitconfig is correct; if you are typing the S-o-b by hand, I recommend figuring out how to get git to do it for you. > --- > 161 files changed, 439 insertions(+), 320 deletions(-) > create mode 100644 include/qemu/bcd.h > create mode 100644 include/qemu/cutils.h > create mode 100644 include/qemu/help_option.h > create mode 100644 include/qemu/id.h > create mode 100644 include/qemu/path.h > create mode 100644 include/qemu/unicode.h This is a big patch. To make review easier, I highly suggest that you repost this as a series of (at least) 6 patches, one per file (if any one include file is huge, it might help to further break it down into 2-3 related functions per patch rather than all functions belonging to the file). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GBw4nCSef42QhKgQMURKECG9W9LRBkCrP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW8zIFAAoJEKeha0olJ0NqWTIH/Azi5ttemFbYC+jDgV/MmlxJ uQM0ou2aI945umYjNn147KCMzS8lWBIH3h1W5WPzbzGqoDADIropEcVzAGLZDblW cBSiR/n4I+ZoiO1NhkbgEEI5YT80q0lOoYDeP6FwpL5sectcIkz6EU/hVdtnwzkD siQWiGjrofdEnFeBmW1wnxE3UKxd6T8dSFkLdSYRxn25o4KO37ri61sBY9nE3tgW slAM9W0jPF+MVjGFDE4m6B2T/nD3BMYyWowRsfQtCNrNk5+FXuiY119jVvjxOKwM 4Nx7yYrs5yaSxA7vopChB0tf7h+NtEr8msZgUBT9PsMda0c5rEG2mIOBdzmArTw= =eafJ -----END PGP SIGNATURE----- --GBw4nCSef42QhKgQMURKECG9W9LRBkCrP--