* [Qemu-devel] [PATCH] pci-testdev: fast mmio support
@ 2016-03-24 13:10 Michael S. Tsirkin
2016-03-24 13:16 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2016-03-24 13:10 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini
Teach PCI testdev to use fast MMIO when kvm makes it available.
Before:
mmio-wildcard-eventfd:pci-mem 2271
After:
mmio-wildcard-eventfd:pci-mem 1218
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/misc/pci-testdev.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/misc/pci-testdev.c b/hw/misc/pci-testdev.c
index 5df9089..2f2e989 100644
--- a/hw/misc/pci-testdev.c
+++ b/hw/misc/pci-testdev.c
@@ -239,6 +239,7 @@ static void pci_testdev_realize(PCIDevice *pci_dev, Error **errp)
uint8_t *pci_conf;
char *name;
int r, i;
+ bool fastmmio = kvm_ioeventfd_any_length_enabled();
pci_conf = pci_dev->config;
@@ -261,8 +262,12 @@ static void pci_testdev_realize(PCIDevice *pci_dev, Error **errp)
memcpy(test->hdr->name, name, strlen(name) + 1);
g_free(name);
test->hdr->offset = cpu_to_le32(IOTEST_SIZE(i) + i * IOTEST_ACCESS_WIDTH);
- test->size = IOTEST_ACCESS_WIDTH;
test->match_data = strcmp(IOTEST_TEST(i), "wildcard-eventfd");
+ if (fastmmio && IOTEST_IS_MEM(i) && !test->match_data) {
+ test->size = 0;
+ } else {
+ test->size = IOTEST_ACCESS_WIDTH;
+ }
test->hdr->test = i;
test->hdr->data = test->match_data ? IOTEST_DATAMATCH : IOTEST_NOMATCH;
test->hdr->width = IOTEST_ACCESS_WIDTH;
--
MST
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] pci-testdev: fast mmio support
2016-03-24 13:10 [Qemu-devel] [PATCH] pci-testdev: fast mmio support Michael S. Tsirkin
@ 2016-03-24 13:16 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2016-03-24 13:16 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
On 24/03/2016 14:10, Michael S. Tsirkin wrote:
> Teach PCI testdev to use fast MMIO when kvm makes it available.
>
> Before:
> mmio-wildcard-eventfd:pci-mem 2271
> After:
> mmio-wildcard-eventfd:pci-mem 1218
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/misc/pci-testdev.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/hw/misc/pci-testdev.c b/hw/misc/pci-testdev.c
> index 5df9089..2f2e989 100644
> --- a/hw/misc/pci-testdev.c
> +++ b/hw/misc/pci-testdev.c
> @@ -239,6 +239,7 @@ static void pci_testdev_realize(PCIDevice *pci_dev, Error **errp)
> uint8_t *pci_conf;
> char *name;
> int r, i;
> + bool fastmmio = kvm_ioeventfd_any_length_enabled();
>
> pci_conf = pci_dev->config;
>
> @@ -261,8 +262,12 @@ static void pci_testdev_realize(PCIDevice *pci_dev, Error **errp)
> memcpy(test->hdr->name, name, strlen(name) + 1);
> g_free(name);
> test->hdr->offset = cpu_to_le32(IOTEST_SIZE(i) + i * IOTEST_ACCESS_WIDTH);
> - test->size = IOTEST_ACCESS_WIDTH;
> test->match_data = strcmp(IOTEST_TEST(i), "wildcard-eventfd");
> + if (fastmmio && IOTEST_IS_MEM(i) && !test->match_data) {
> + test->size = 0;
> + } else {
> + test->size = IOTEST_ACCESS_WIDTH;
> + }
> test->hdr->test = i;
> test->hdr->data = test->match_data ? IOTEST_DATAMATCH : IOTEST_NOMATCH;
> test->hdr->width = IOTEST_ACCESS_WIDTH;
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-24 13:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-24 13:10 [Qemu-devel] [PATCH] pci-testdev: fast mmio support Michael S. Tsirkin
2016-03-24 13:16 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).