From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj58I-0000E6-Fd for qemu-devel@nongnu.org; Thu, 24 Mar 2016 09:17:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aj58E-0004q4-Es for qemu-devel@nongnu.org; Thu, 24 Mar 2016 09:17:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj58E-0004pw-9E for qemu-devel@nongnu.org; Thu, 24 Mar 2016 09:16:58 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id CDDE78E3DA for ; Thu, 24 Mar 2016 13:16:57 +0000 (UTC) References: <1458825035-21171-1-git-send-email-mst@redhat.com> From: Paolo Bonzini Message-ID: <56F3E8C6.3020302@redhat.com> Date: Thu, 24 Mar 2016 14:16:54 +0100 MIME-Version: 1.0 In-Reply-To: <1458825035-21171-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pci-testdev: fast mmio support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org On 24/03/2016 14:10, Michael S. Tsirkin wrote: > Teach PCI testdev to use fast MMIO when kvm makes it available. > > Before: > mmio-wildcard-eventfd:pci-mem 2271 > After: > mmio-wildcard-eventfd:pci-mem 1218 > > Signed-off-by: Michael S. Tsirkin > --- > hw/misc/pci-testdev.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/hw/misc/pci-testdev.c b/hw/misc/pci-testdev.c > index 5df9089..2f2e989 100644 > --- a/hw/misc/pci-testdev.c > +++ b/hw/misc/pci-testdev.c > @@ -239,6 +239,7 @@ static void pci_testdev_realize(PCIDevice *pci_dev, Error **errp) > uint8_t *pci_conf; > char *name; > int r, i; > + bool fastmmio = kvm_ioeventfd_any_length_enabled(); > > pci_conf = pci_dev->config; > > @@ -261,8 +262,12 @@ static void pci_testdev_realize(PCIDevice *pci_dev, Error **errp) > memcpy(test->hdr->name, name, strlen(name) + 1); > g_free(name); > test->hdr->offset = cpu_to_le32(IOTEST_SIZE(i) + i * IOTEST_ACCESS_WIDTH); > - test->size = IOTEST_ACCESS_WIDTH; > test->match_data = strcmp(IOTEST_TEST(i), "wildcard-eventfd"); > + if (fastmmio && IOTEST_IS_MEM(i) && !test->match_data) { > + test->size = 0; > + } else { > + test->size = IOTEST_ACCESS_WIDTH; > + } > test->hdr->test = i; > test->hdr->data = test->match_data ? IOTEST_DATAMATCH : IOTEST_NOMATCH; > test->hdr->width = IOTEST_ACCESS_WIDTH; > Acked-by: Paolo Bonzini