qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Li, Liang Z" <liang.z.li@intel.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Cc: "rkagan@virtuozzo.com" <rkagan@virtuozzo.com>,
	"linux-kernel@vger.kenel.org" <linux-kernel@vger.kenel.org>,
	"ehabkost@redhat.com" <ehabkost@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"quintela@redhat.com" <quintela@redhat.com>,
	"simhan@hpe.com" <simhan@hpe.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"dgilbert@redhat.com" <dgilbert@redhat.com>,
	"jitendra.kolhe@hpe.com" <jitendra.kolhe@hpe.com>,
	"mohan_parthasarathy@hpe.com" <mohan_parthasarathy@hpe.com>,
	"amit.shah@redhat.com" <amit.shah@redhat.com>,
	"rth@twiddle.net" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages
Date: Thu, 24 Mar 2016 16:47:36 +0100	[thread overview]
Message-ID: <56F40C18.3020305@redhat.com> (raw)
In-Reply-To: <F2CBF3009FA73547804AE4C663CAB28E0415C004@shsmsx102.ccr.corp.intel.com>



On 24/03/2016 16:39, Li, Liang Z wrote:
> > Only if you write the arch specific thing for all arches.
> 
> I plan to keep a function stub for each arch to implement. And I
> have done that for X86.

Again: the ram_addr_t matching is internal to QEMU and can vary from
release to release.  Do not do this.

> > I think the reason for the speedup that you observe is that you only need to
> > translate ram_addr_t to GPA once per ramblock, which is much faster than
> > translating GPA to ram_addr_t for each page.
> 
> Yes, exactly! 

You don't need to translate it once per page.  When QEMU copies the
bitmap from guest memory to its own internal data structures, it can do
so one block at a time with a function like

    void bitmap_copy_bits(unsigned long *dst, unsigned int dst_start,
                          unsigned long *src, unsigned int src_start
			  unsigned int nbits);

Paolo

  reply	other threads:[~2016-03-24 15:47 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22  7:43 [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages Liang Li
2016-03-22 10:11 ` Michael S. Tsirkin
2016-03-23  6:05   ` Li, Liang Z
2016-03-23 14:08     ` Michael S. Tsirkin
2016-03-24  1:19       ` Li, Liang Z
2016-03-24  9:48         ` Michael S. Tsirkin
2016-03-24 10:16           ` Li, Liang Z
2016-03-24 10:29             ` Michael S. Tsirkin
2016-03-24 14:33               ` Li, Liang Z
2016-03-24 14:44                 ` Michael S. Tsirkin
2016-03-24 15:16                   ` Li, Liang Z
2016-03-24 15:18                     ` Paolo Bonzini
2016-03-24 15:25                       ` Li, Liang Z
2016-03-24 15:27                     ` Michael S. Tsirkin
2016-03-24 15:39                       ` Li, Liang Z
2016-03-24 15:47                         ` Paolo Bonzini [this message]
2016-03-24 15:59                           ` Li, Liang Z
2016-03-22 19:05 ` Dr. David Alan Gilbert
2016-03-23  6:48   ` Li, Liang Z
2016-03-24  1:24     ` Wei Yang
2016-03-24  9:00       ` Dr. David Alan Gilbert
2016-03-24 10:09         ` Li, Liang Z
2016-03-24 10:23           ` Dr. David Alan Gilbert
2016-03-24 14:50             ` Li, Liang Z
2016-03-24 15:11               ` Michael S. Tsirkin
2016-03-24 15:53                 ` Li, Liang Z
2016-03-24 15:56                   ` Michael S. Tsirkin
2016-03-24 16:05                     ` Li, Liang Z
2016-03-24 16:25                       ` Michael S. Tsirkin
2016-03-24 17:49                         ` Dr. David Alan Gilbert
2016-03-24 22:16                           ` Michael S. Tsirkin
2016-03-25  1:59                             ` Li, Liang Z
2016-03-25  1:32                           ` Li, Liang Z
2016-04-18 11:08                           ` Li, Liang Z
2016-04-18 11:29                             ` Michael S. Tsirkin
2016-04-18 14:36                               ` Li, Liang Z
2016-04-18 15:38                                 ` Michael S. Tsirkin
2016-04-19  2:20                                   ` Li, Liang Z
2016-04-19 19:12                               ` Dr. David Alan Gilbert
2016-04-25 10:56                                 ` Michael S. Tsirkin
2016-04-19 19:05                             ` Dr. David Alan Gilbert
2016-04-20  3:22                               ` Li, Liang Z
2016-04-20  8:10                                 ` Dr. David Alan Gilbert
2016-03-25  1:32                         ` Li, Liang Z
2016-04-01 10:54   ` Amit Shah
2016-04-05  1:49     ` Li, Liang Z
2016-03-23  1:37 ` Wei Yang
2016-03-23  7:18   ` Li, Liang Z
2016-03-23  9:46     ` Wei Yang
2016-03-23 14:35       ` Li, Liang Z
2016-03-24  0:52         ` Wei Yang
2016-03-24  1:32           ` Li, Liang Z
2016-03-24  1:56             ` Wei Yang
2016-03-23 16:53     ` Eric Blake
2016-03-23 21:41       ` Wei Yang
2016-03-24  1:23       ` Li, Liang Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F40C18.3020305@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jitendra.kolhe@hpe.com \
    --cc=kvm@vger.kernel.org \
    --cc=liang.z.li@intel.com \
    --cc=linux-kernel@vger.kenel.org \
    --cc=mohan_parthasarathy@hpe.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rkagan@virtuozzo.com \
    --cc=rth@twiddle.net \
    --cc=simhan@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).