From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj7nu-0002W7-1K for qemu-devel@nongnu.org; Thu, 24 Mar 2016 12:08:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aj7no-0001YZ-Vr for qemu-devel@nongnu.org; Thu, 24 Mar 2016 12:08:09 -0400 Received: from mail-lb0-x244.google.com ([2a00:1450:4010:c04::244]:35761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj7no-0001Xu-GH for qemu-devel@nongnu.org; Thu, 24 Mar 2016 12:08:04 -0400 Received: by mail-lb0-x244.google.com with SMTP id oa3so3715513lbb.2 for ; Thu, 24 Mar 2016 09:08:04 -0700 (PDT) References: <1458753657-21664-1-git-send-email-alex.bennee@linaro.org> <1458753657-21664-5-git-send-email-alex.bennee@linaro.org> <56F3B20A.9010607@gmail.com> <87shzgqdx4.fsf@linaro.org> <56F3DA80.7050003@gmail.com> <87bn63rhdk.fsf@linaro.org> From: Sergey Fedorov Message-ID: <56F410D3.6030105@gmail.com> Date: Thu, 24 Mar 2016 19:07:47 +0300 MIME-Version: 1.0 In-Reply-To: <87bn63rhdk.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 4/5] ./configure: accept stems to match a range of targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au On 24/03/16 19:05, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 24/03/16 15:05, Alex Bennée wrote: >>> Sergey Fedorov writes: >>> >>>> On 23/03/16 20:20, Alex Bennée wrote: >>>>> diff --git a/configure b/configure >>>>> index b88d0db..ebf8a42 100755 >>>>> --- a/configure >>>>> +++ b/configure >>>>> @@ -1246,7 +1246,8 @@ Standard options: >>>>> --target-list=LIST set target list (default: build everything) >>>>> $(echo Available targets: $default_target_list | \ >>>>> fold -s -w 53 | sed -e 's/^/ /') >>>>> - >>>>> + LIST can contain stems to match sets of targets >>>>> + (e.g. softmmu will match all softmmu targets) >>>>> Advanced options (experts only): >>>>> --source-path=PATH path of source code [$source_path] >>>>> --cross-prefix=PREFIX use PREFIX for compile tools [$cross_prefix] >>>> Maybe we'd better require user to specify the exact glob patterns in >>>> '--target-list' to avoid possible misuse? >>> Don't you run into problems of escaping glob patterns from the shell and >>> the like? For example if I do: >>> >>> 12:04 alex@zen/x86_64 [qemu.git/mttcg/base-patches-v2] >./configure >>> --target-list=arm* >>> >>> ERROR: Unknown target name 'arm-softmmu-config-devices.mak.d' >>> >>> As the shell picks up file names from the src dir. >>> >> Of course, it would be necessary to quote it like this: >> >> ./configure --target-list='arm*' > Hmm shell quoting is a black art it seems: > > 16:04 alex@zen/x86_64 [qemu.git/travis/add-trusty-gce] >./configure --target-list='ar*' > > ERROR: Unknown target name 'arch_init.c' Right, it's inherent problem, I think :)