qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Jason Wang <jasowang@redhat.com>, mst@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] tap: vhost busy polling support
Date: Thu, 24 Mar 2016 14:34:13 -0600	[thread overview]
Message-ID: <56F44F45.7000405@redhat.com> (raw)
In-Reply-To: <1458537955-8032-3-git-send-email-jasowang@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

On 03/20/2016 11:25 PM, Jason Wang wrote:
> This patch add the capability of basic vhost net busy polling which is
> supported by recent kernel. User could configure the maximum number of
> us that could be spent on busy polling through a new property of tap
> "vhost_poll_us".
> 
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---

> +++ b/qapi-schema.json
> @@ -2532,7 +2532,8 @@
>      '*vhostfd':    'str',
>      '*vhostfds':   'str',
>      '*vhostforce': 'bool',
> -    '*queues':     'uint32'} }
> +    '*queues':     'uint32',
> +    '*vhost_poll_us': 'uint32'} }

Missing documentation.

New interfaces should prefer '-' over '_'; but this is an existing
interface where we already have 'vnet_hdr', so intra-command consistency
makes your naming okay.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  parent reply	other threads:[~2016-03-24 20:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21  5:25 [Qemu-devel] [PATCH 0/2] busy polling support for vhost-kernel Jason Wang
2016-03-21  5:25 ` [Qemu-devel] [PATCH 1/2] update linux headers to 4.5.0-rc5+ Jason Wang
2016-03-21  5:25 ` [Qemu-devel] [PATCH 2/2] tap: vhost busy polling support Jason Wang
2016-03-21  7:26   ` Fam Zheng
2016-03-25  7:45     ` Jason Wang
2016-03-24 20:34   ` Eric Blake [this message]
2016-03-25  7:46     ` Jason Wang
2016-04-05 15:54 ` [Qemu-devel] [PATCH 0/2] busy polling support for vhost-kernel Greg Kurz
2016-04-06  1:49   ` Jason Wang
2016-04-06  7:11     ` Greg Kurz
2016-04-06  9:16       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F44F45.7000405@redhat.com \
    --to=eblake@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).